Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109077
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
In-Reply-To: <4C35AB9D-277D-41AE-8364-83EC1A782F4C@pmjones.io>
Date: Mon, 16 Mar 2020 14:35:36 -0400
Cc: Rowan Tommins <rowan.collins@gmail.com>,
 internals@lists.php.net
Content-Transfer-Encoding: quoted-printable
Message-ID: <19B3A3A7-9AD2-40B8-A7B0-F2E029C26D81@newclarity.net>
References: <50BD013E-CF72-414C-BBC0-A7A2E45CBDDB@pmjones.io>
 <D2321EFF-6D87-422A-BCC3-875820ADF8E2@pmjones.io>
 <C2A122BA-052B-4AFB-900E-93858BF50F7E@koalephant.com>
 <0B40E6E5-342F-4D81-9CAA-A0C0739A7718@pmjones.io>
 <C3C15896-923D-4386-A991-329D0FCE7CC9@koalephant.com>
 <102D234E-BC5D-42B2-ABC4-93980C1F76A4@pmjones.io>
 <a46d0ba9-2981-4c58-afb1-f648c499450e@www.fastmail.com>
 <9c8064d1-52cf-c31d-f023-e323b5c2dce5@gmail.com>
 <4C35AB9D-277D-41AE-8364-83EC1A782F4C@pmjones.io>
To: "Paul M. Jones" <pmjones@pmjones.io>
Subject: Re: [PHP-DEV] RFC: Server-Side Request and Response Objects (v2)
From: mike@newclarity.net (Mike Schinkel)

> On Mar 16, 2020, at 12:04 PM, Paul M. Jones <pmjones@pmjones.io> =
wrote:
>=20
> Turning it over in my mind, I wonder if maybe a `Sapi` prefix would be =
a better alternative along this path, especially since these objects =
relate to the "interface between web server and PHP." =
<https://www.php.net/manual/en/function.php-sapi-name.php> A `Sapi` =
prefix would net us:
>=20
> - SapiRequest
> - SapiResponse
> - SapiResponseSender
>=20
> The only obvious objection is that the SAPI list includes 'cli'. While =
it not strictly outside the realm of the RFC, it certainly is not the =
focus; but then, tests running at the command line will be under the =
'cli' SAPI, so there's at least some sort of rationalization for it.
>=20
> Overall, I think `Sapi` looks better than `Cgi`, and certainly better =
than `Server` or the other names we've considered.
>=20
> Any further thoughts on naming?

That works well IMO.

>> I also just realised that it would make sense to rename $_SERVER in =
the object, the same way $_GET has become "query" and $_POST has become =
"input". Maybe $request->cgi or something?
>=20
> I sympathize with the desire to rename (or even restructure) the =
apparent catchall of `$_SERVER`. But I am still reluctant to do so, =
especially as no other researched projects use a different name here =
(whereas some have replaced `$_GET` with `$query`, etc).
>=20
> Does anyone besides Rowan long for a different property name here? =
What are your suggestions, if any?

I don't think this is important anymore if we call it Sapi or CGI.  It =
was only an issue IMO if if we were still wanting to call it Request.

But again, just my opinion.

-Mike