Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109023
MIME-Version: 1.0
References: <CANOvohpdq6ZJ8gFJTu8OY-Ju5T3cPbZHsDUPKpumBkW=DAeCGA@mail.gmail.com>
In-Reply-To: <CANOvohpdq6ZJ8gFJTu8OY-Ju5T3cPbZHsDUPKpumBkW=DAeCGA@mail.gmail.com>
Date: Sat, 14 Mar 2020 22:23:11 +0100
Message-ID: <CAFPFaMJ=UfdtjfuLXsfQMoboZzpqGsZSw4mQUNZRD1=tEOmtDg@mail.gmail.com>
To: Mark Randall <markyr@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000027261305a0d7320f"
Subject: Re: [PHP-DEV] [Discussion] Promoting declare failure notices to exceptions?
From: george.banyard@gmail.com ("G. P. B.")

--00000000000027261305a0d7320f
Content-Type: text/plain; charset="UTF-8"

On Sat, 14 Mar 2020 at 21:19, Mark Randall <markyr@gmail.com> wrote:

> Greetings,
>
> I have created a PR that will throw exceptions when using define()
> with invalid types or when trying to redefine.
>
> Trying to redefine a constant or define a bad constant would throw a
> ValueError on the name parameter, trying to pass an unsupported type
> would give a TypeError on the value parameter.
>
> Normal promotions are fairly run of the mill, however for some utterly
> bizarre reason the existing behaviour is to print a notice and not a
> warning as with almost all other functions that are failing.
>
> Is there a good reason not to promote these to exceptions?
>
> https://github.com/php/php-src/pull/5265
>
> --
> Mark Randall
> marandall@php.net
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php


I'm all for it, I wouldn't a lot of code to be affected by it as that code
would be truly broken.

Best regards

George P. Banyard

--00000000000027261305a0d7320f--