Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:109020 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 53187 invoked from network); 14 Mar 2020 21:57:56 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 14 Mar 2020 21:57:56 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 8FC541804AB for ; Sat, 14 Mar 2020 13:19:54 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_05,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sat, 14 Mar 2020 13:19:54 -0700 (PDT) Received: by mail-il1-f179.google.com with SMTP id f5so12501505ilq.5 for ; Sat, 14 Mar 2020 13:19:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=vYYpyK35UmwmC0p4B2lkNrcN/3kDY+YHRonrQLLROvc=; b=OpM8W5ZXmkgDRv+dnUhR5V6b+565f/kc+1t5ESyZIVEh4dpm1g5fPSCFHy/klOc1En cRRM4hTtsIaE+68iX8CdZWtOZP5i+gu4z4EOLo9wcdKf0fmRGmnAQeJsRwHxoNAQgm6C otCe+5N+9oOHpSDkPXpdCDL5MhpSk9lusvVzWTj25Tc7Mo6zLZfFqWlsuIZG/6Wdbm4L gEnHYlnvRRBqjx445cxn1sPc9ehrbfRtR5cTmAc/puV7r6lE9cA/z0sx7QPWBqRla8S6 lbK9eCi8ZgjK3iA84MVwUxodmGPgPV2mhfPY2Bq1sCU/m1Y9Ay70JjRPwnKUO/6xAC3L YZEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=vYYpyK35UmwmC0p4B2lkNrcN/3kDY+YHRonrQLLROvc=; b=b4eq7yOEYD9Z4SZCT+4/tI9N4+ZVuzxoy0GXQwA3XyK6OptLrxEyU0ntyBcqmKyyHt ZfOoWE3huq5FcooZEwSBnwOGRrlaJJQF6GoUOR1U+z1clSLQatFKckeMx/Dcqu/+DZFM 1V28+b7bMDU0hpR79/pAgkpTVdyF6UsZH9RgEOrUUZGYlQOTxrbJ5bCZBGia6ike5bLH OyFgJzl81wxRZDBrWkHCpAU90jPDaLSNJFPKte93bT85WnSa9LAGJPKhJT0gTwbfo+vw hXHsshBjR2i6bapbSv9ZzmIBw5aX7e0AbEb825CmPZfOVlCtCpDG+AMMzlOJZWlFX4ig hHtw== X-Gm-Message-State: ANhLgQ2k3ZI2Alpin7iGE9pBNNBG3CYpRGYJJIR3EC451+Oupxka3cil 0RoGm5tlGCaa+8ApQ+1eeWR3nLMtvPkuVhghOSsYAZ5O X-Google-Smtp-Source: ADFU+vs3g3h8ON6lIAt8POPdau+Zfht5HPUC0WyH6ocoP1TD0EwBDkvtSxUnhmfVp6g0mEx27KpdZT0omv2dX7PIwWc= X-Received: by 2002:a05:6e02:511:: with SMTP id d17mr16157554ils.36.1584217190288; Sat, 14 Mar 2020 13:19:50 -0700 (PDT) MIME-Version: 1.0 Date: Sat, 14 Mar 2020 20:19:39 +0000 Message-ID: To: internals@lists.php.net Content-Type: text/plain; charset="UTF-8" Subject: [Discussion] Promoting declare failure notices to exceptions? From: markyr@gmail.com (Mark Randall) Greetings, I have created a PR that will throw exceptions when using define() with invalid types or when trying to redefine. Trying to redefine a constant or define a bad constant would throw a ValueError on the name parameter, trying to pass an unsupported type would give a TypeError on the value parameter. Normal promotions are fairly run of the mill, however for some utterly bizarre reason the existing behaviour is to print a notice and not a warning as with almost all other functions that are failing. Is there a good reason not to promote these to exceptions? https://github.com/php/php-src/pull/5265 -- Mark Randall marandall@php.net