Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109015
To: PHP Internals <internals@lists.php.net>
Message-ID: <99c00084-c212-ad23-628e-87f35e2de849@allenjb.me.uk>
Date: Sat, 14 Mar 2020 15:40:30 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Subject: Changing the default PDO error mode
From: php.lists@allenjb.me.uk (AllenJB)

Hi all,

A regular problem that new users run into is error handling with PDO. 
The current default error mode for PDO is "silent". This leads to the 
situation where code doesn't work and returns no obvious errors unless 
PDO specific error handling code is explicitly added.

I would like to propose the default error mode be changed from PHP 8 as 
I believe this would make PDO error handling much more intuitive for new 
developers, preventing the common "my code isn't working and I don't 
know why" scenario that occurs.

While a BC break, I believe it's the type of change developers expect in 
a major version and I don't believe that explicitly setting the error 
mode for code bases that rely on the silent error mode is onerous - many 
code bases are already explicitly setting the error mode already.

Given the way error handling has been / is heading in PHP, I would 
suggest the default error mode should be exceptions, but I can forsee 
arguments for using warnings instead ("less of a BC break" since code 
would still continue unless a custom error handler causes an abort, so 
closer to the behavior of "silent").

What are peoples views on making this change?

What do you think the new default be (and why)?

(I am aware this change will likely require an RFC)

AllenJB