Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109003
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
In-Reply-To: <102D234E-BC5D-42B2-ABC4-93980C1F76A4@pmjones.io>
Date: Fri, 13 Mar 2020 14:40:36 -0400
Cc: Stephen Reay <php-lists@koalephant.com>,
 PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <C7DFAE61-258A-4525-8946-6FA057CE431F@newclarity.net>
References: <50BD013E-CF72-414C-BBC0-A7A2E45CBDDB@pmjones.io>
 <D2321EFF-6D87-422A-BCC3-875820ADF8E2@pmjones.io>
 <C2A122BA-052B-4AFB-900E-93858BF50F7E@koalephant.com>
 <0B40E6E5-342F-4D81-9CAA-A0C0739A7718@pmjones.io>
 <C3C15896-923D-4386-A991-329D0FCE7CC9@koalephant.com>
 <102D234E-BC5D-42B2-ABC4-93980C1F76A4@pmjones.io>
To: "Paul M. Jones" <pmjones@pmjones.io>
Subject: Re: [PHP-DEV] RFC: Server-Side Request and Response Objects (v2)
From: mike@newclarity.net (Mike Schinkel)


> On Mar 13, 2020, at 10:55 AM, Paul M. Jones <pmjones@pmjones.io> =
wrote:
>=20
> One other alternative John & I contemplated was =
`Web{Request,Response,ResponseSender}` -- do you think that might be a =
reasonable alternative to HTTP, one that is "adjacent" but not =
overly-specific? That would net us:
>=20
> - WebRequest
> - WebResponse
> - WebResponseSender
>=20
> I didn't like the look of it previously, and I don't think I like the =
look of it now, but ... (/me shrugs).
>=20
>=20
>> However, that also may be confusing if people expect it to be a =
construct for making outgoing requests.=20
>=20
> Yes, that's another tricky bit in the naming -- making a distinction =
between the objects as representative of client operations (send =
request, receive response) and server operations (receive request, send =
response). Thus the current `Server` prefix (however unsatisfactory it =
may be) to indicate their operational context.
>=20
> Your `Incoming` and `Outgoing` prefixes, minus the HTTP, would net us:
>=20
> - IncomingRequest
> - OutgoingResponse
> - OutgoingResponseSender
>=20
> I will need to ponder on those.
>=20
>> The user land implementation I=E2=80=99ve been using =E2=80=99solves=E2=
=80=99 this by using a `HTTP` namespace, and then provides `Request` and =
`Response` (for an outgoing - i.e. curl - HTTP Request, and the =
corresponding HTTP Response) objects and then `CurrentRequest` and =
`CurrentResponse` for what your RFC proposes (i.e. the active request =
made to php).=20
>=20
> Yes, userland does operate that way. However, I think adding an HTTP =
namespace to PHP itself is something to be avoided, so emulating =
userland here is not an option.
>=20
>=20
>> As with anything any of us has written, I=E2=80=99m not 100% sold on =
=E2=80=98Current{Request,Response}` even after writing it, but I think =
it=E2=80=99s at least a little more specific about what they do, when =
the namespace is taken into account.
>=20
> `Current{...}` is not something we had previously considered; that =
would net us, in the global namespace:
>=20
> - CurrentRequest
> - CurrentResponse
> - CurrentResponseSender
>=20
> I will need to ponder on those as well.
>=20
> Any further thoughts or opinions on this, Stephen? Or from anyone =
else?

One issue that I have is, if we are going to fine-tune the naming to =
make sure it matches  *exactly* then I think that CurrentRequest->server =
does not make sense.

Maybe if you choose one of these names you should break out the =
server-specific items into their own class/object?

-Mike=