Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108982
User-Agent: Cyrus-JMAP/3.1.7-991-g5a577d3-fmstable-20200305v3
Mime-Version: 1.0
Message-ID: <41f72798-b464-4ae9-8b57-c3b2b984f39c@www.fastmail.com>
In-Reply-To: 
 <CAF+90c-Gs0-XWfeHN6NWAUPq9eDzCmwN52b-BW1XbC4rH9uTcg@mail.gmail.com>
References: 
 <CAF+90c8xHmxy9DL2cdqc3beNquJ=A6z0+RB8ggwZ6v+a1ixFuw@mail.gmail.com>
 <1715830.3Z3xILz1Hf@mcmic-probook>
 <CAF+90c_uK4k_sg8RgG5JWZAwbJz+gEqvA7c1kaEDUtcfVWTmiA@mail.gmail.com>
 <8165930.V9hoPP6r1K@mcmic-probook>
 <CAF+90c-Gs0-XWfeHN6NWAUPq9eDzCmwN52b-BW1XbC4rH9uTcg@mail.gmail.com>
Date: Wed, 11 Mar 2020 10:59:19 -0500
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [VOTE] Object-based token_get_all() alternative
From: larry@garfieldtech.com ("Larry Garfield")

On Wed, Mar 11, 2020, at 4:57 AM, Nikita Popov wrote:
> On Tue, Mar 10, 2020 at 5:19 PM C=C3=B4me Chilliet <
> come.chilliet@fusiondirectory.org> wrote:
>=20
> > Le mardi 10 mars 2020, 15:53:41 CET Nikita Popov a =C3=A9crit :
> > > Would __toString() return $token->text? I'm not strictly opposed t=
o this,
> > > but I'd be hard pressed to think of a situation where I would pref=
er
> > > writing (string) $token over $token->text. Generally, the less mag=
ic the
> > > better :)
> >
> > My idea was that since tokens are parsed from a string it should be =
easy
> > to write a string back with them.
> > I do not have an obvious usecase but the idea is doing stuff like
> >
> > if ($token.is('function')) {
> >         echo "public $token";
> > } else {
> >         echo $token;
> > }
> >
> > Am I right to assume that with __toString the same as ->text we=E2=80=
=99d have
> > implode('', PhpToken::getAll($code)) =3D=3D $code ?
> >
> > This would allow:
> > $tokens =3D PhpToken::getAll($code);
> > // Modifications on $tokens
> > $code =3D implode('', $tokens);
> >
>=20
> Yes, that would work. It's not much harder without __toString though:
>=20
> $code =3D implode(array_column($tokens, 'text'));
>=20
> Does anyone else have thoughts on whether PhpToken should implement
> __toString() or not?
>=20
> Nikita

I forget who it was but someone on the list a while back offered a heuri=
stic of "__toString should be used iff there is one and only one logical=
 string representation of a value, because the value is conceptually jus=
t a string with extra metadata on it".

That sounds like a really solid heuristic to me.  In this case, I think =
yes, ->text is the only reasonable thing to produce for __toString(). =20=


Or perhaps this is a good use case for "you can use a subclass, do that"=
 if there's any good reason to not have it just be ->text.

--Larry Garfield