Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108972
MIME-Version: 1.0
References: <CAF+90c8xHmxy9DL2cdqc3beNquJ=A6z0+RB8ggwZ6v+a1ixFuw@mail.gmail.com>
 <1715830.3Z3xILz1Hf@mcmic-probook> <CAF+90c_uK4k_sg8RgG5JWZAwbJz+gEqvA7c1kaEDUtcfVWTmiA@mail.gmail.com>
 <8165930.V9hoPP6r1K@mcmic-probook>
In-Reply-To: <8165930.V9hoPP6r1K@mcmic-probook>
Date: Wed, 11 Mar 2020 10:57:16 +0100
Message-ID: <CAF+90c-Gs0-XWfeHN6NWAUPq9eDzCmwN52b-BW1XbC4rH9uTcg@mail.gmail.com>
To: =?UTF-8?Q?C=C3=B4me_Chilliet?= <come.chilliet@fusiondirectory.org>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000daa5df05a09143d4"
Subject: Re: [PHP-DEV] [VOTE] Object-based token_get_all() alternative
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000daa5df05a09143d4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 10, 2020 at 5:19 PM C=C3=B4me Chilliet <
come.chilliet@fusiondirectory.org> wrote:

> Le mardi 10 mars 2020, 15:53:41 CET Nikita Popov a =C3=A9crit :
> > Would __toString() return $token->text? I'm not strictly opposed to thi=
s,
> > but I'd be hard pressed to think of a situation where I would prefer
> > writing (string) $token over $token->text. Generally, the less magic th=
e
> > better :)
>
> My idea was that since tokens are parsed from a string it should be easy
> to write a string back with them.
> I do not have an obvious usecase but the idea is doing stuff like
>
> if ($token.is('function')) {
>         echo "public $token";
> } else {
>         echo $token;
> }
>
> Am I right to assume that with __toString the same as ->text we=E2=80=99d=
 have
> implode('', PhpToken::getAll($code)) =3D=3D $code ?
>
> This would allow:
> $tokens =3D PhpToken::getAll($code);
> // Modifications on $tokens
> $code =3D implode('', $tokens);
>

Yes, that would work. It's not much harder without __toString though:

$code =3D implode(array_column($tokens, 'text'));

Does anyone else have thoughts on whether PhpToken should implement
__toString() or not?

Nikita

--000000000000daa5df05a09143d4--