Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108910
MIME-Version: 1.0
References: <CAEPJdunSr8PkBtSLO8g_JMLzM4cFVnXsQSEMFmu2RN25XT=grw@mail.gmail.com>
 <7BAB0436-03EC-4183-BA5A-5A165DAE806E@koalephant.com>
In-Reply-To: <7BAB0436-03EC-4183-BA5A-5A165DAE806E@koalephant.com>
Date: Mon, 9 Mar 2020 17:27:19 +0100
Message-ID: <CAEPJdu=dwV32bZ8hs8_9GT+qvncOcxFEQdxtuDUpobCW0HFKrQ@mail.gmail.com>
To: Stephen Reay <php-lists@koalephant.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c8e08705a06e7ae4"
Subject: Re: [PHP-DEV] [RFC] Attributes v2
From: kontakt@beberlei.de (Benjamin Eberlei)

--000000000000c8e08705a06e7ae4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 9, 2020 at 5:18 PM Stephen Reay <php-lists@koalephant.com>
wrote:

>
>
> > On 9 Mar 2020, at 21:42, Benjamin Eberlei <kontakt@beberlei.de> wrote:
> >
> > Hi all,
> >
> > I want to resurrect Dmitrys Attributes RFC that was rejected for 7.1 in
> > 2016 with a few changes, incorporating feedback from the mailing list
> back
> > then and from talking to previous no voters.
> >
> > The RFC is at https://wiki.php.net/rfc/attributes_v2
> >
> > A working patch is at https://github.com/beberlei/php-src/pull/2 though
> > work around the details is still necessary.
> >
> > The RFC contains a section with common criticism and objections to
> > attributes, and I hope to have collected and responded to a good amount
> > already from previous discussions.
> >
> > There is also a fair amount of implementation detail still up for debat=
e,
> > which is noted in "Open Issues". I have pre-committed to one approach,
> but
> > listed alternatives there. On these issues I am looking for your
> feedback.
> >
> > greetings
> > Benjamin
>
> Hi Benjamin,
>
> I can=E2=80=99t comment on the feasibility of this RFC or the patch, but =
I like
> the approach it takes to this =E2=80=98problem=E2=80=99. I can already im=
agine a number of
> =E2=80=98nicer=E2=80=99 ways to achieve similar/same results using this, =
so thanks for
> taking up the baton!
>
> My one small query/request is about the `Reflection*::getAttributes`
> method. Is there a philosophical and/or technological reason for why it c=
an
> only =E2=80=98filter=E2=80=99 the attributes by a single given name, rath=
er than being
> variadic and filtering against multiple names (i.e. returning those that
> match any of the given names)? I would imagine many uses (particularly
> within libraries) would end up wanting to retrieve multiple attribute typ=
es
> they=E2=80=99re aware of all at once, no?
>

The name filtering works when using a common base class or interface, so if
a library has a class "My\BaseAttribute" and all related attributes extend
from it, then in the code you can do:

$attributes =3D $reflectionClass->getAttributes(\My\BaseAttribute::class);

This would return all attributes matching.

>
>
> Cheers
>
>
> Stephen

--000000000000c8e08705a06e7ae4--