Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108894
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
In-Reply-To: <CAL0xaBHYBrLhNSjDv5-anE15rp6qsbW-S7mHfxuBvq12OTyN6g@mail.gmail.com>
Date: Sat, 7 Mar 2020 16:50:12 -0600
Cc: php internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <38289BE3-41F1-4738-A3E0-0D9174A9F732@pmjones.io>
References: <50BD013E-CF72-414C-BBC0-A7A2E45CBDDB@pmjones.io>
 <1657AB79-5CAF-4BCA-96B5-1343EC703CCD@pmjones.io>
 <CAL0xaBHYBrLhNSjDv5-anE15rp6qsbW-S7mHfxuBvq12OTyN6g@mail.gmail.com>
To: Arvids Godjuks <arvids.godjuks@gmail.com>
Subject: Re: [PHP-DEV] RFC: Server-Side Request and Response Objects (v2)
From: pmjones@pmjones.io ("Paul M. Jones")

Hi Arvids,

> On Mar 5, 2020, at 05:19, Arvids Godjuks <arvids.godjuks@gmail.com> =
wrote:
>=20
> one question I do have here is about how PHP-PM process manager will =
be
> able to interact with this layer?
> Cause right now it does rewrite the $_SERVER variable for each =
incoming
> request for its child processes that handle the requests
> =
https://github.com/php-pm/php-pm/blob/a2872e13c3901401d5c2386a8ed62502db23=
d5f2/src/ProcessSlave.php#L463
>=20
> It kind'a makes this not possible if there is no way to re-init the =
object.
> While read-only is, obviously, a good idea, there are some caveats =
like
> this that not only limit the possibilities but also what will the
> ServerRequest object even look like when $_SERVER is being rewritten =
like
> this?
>=20
> ...
>=20
> it seems that this RFC does not allow such usage at all and =
long-running processing has not been taken into account at all?

I have never used PHP-PM, so I am talking outside my competence here.

Even so, I see the ProcessSlave::prepareEnvironment() method rewrites =
$_SERVER. Instead of re-initializing an existing object, would it be =
sufficient to create a new ServerRequest object after that point, with =
the newly-modified $GLOBALS values (in which $_SERVER is represented)? =
You would then use that new instance in the new child process.

Regarding a long-running process, I could see where the entry point =
might create a new instance of ServerRequest as needed, using the =
current $GLOBALS state, and pass that new instance into whatever handler =
gets invoked.

I am probably missing your point; if so, my apologies, and please guide =
me.


--=20
Paul M. Jones
pmjones@pmjones.io
http://paul-m-jones.com

Modernizing Legacy Applications in PHP
https://leanpub.com/mlaphp

Solving the N+1 Problem in PHP
https://leanpub.com/sn1php