Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108831
MIME-Version: 1.0
References: <CAF+90c-0KDuso8sz0JRcusmadJ6RkVN3Ssp1CeuHbX2v2dXypg@mail.gmail.com>
In-Reply-To: <CAF+90c-0KDuso8sz0JRcusmadJ6RkVN3Ssp1CeuHbX2v2dXypg@mail.gmail.com>
Reply-To: bishop@php.net
Date: Tue, 3 Mar 2020 10:57:27 -0500
Message-ID: <CAEYWF=698BY3uDCzGavt=STJjGy9GTvn8p7dsAixsLzURK6QFw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000700095059ff55efe"
Subject: Re: [PHP-DEV] Require non-absolute trait method references to be unambiguous
From: bishop@php.net (Bishop Bettini)

--000000000000700095059ff55efe
Content-Type: text/plain; charset="UTF-8"

On Tue, Mar 3, 2020 at 9:11 AM Nikita Popov <nikita.ppv@gmail.com> wrote:

> Currently, when writing something like
>
>     use T1, T2 {
>         func as renamedFunc;
>     }
>
> where both T1::func() and T2::func() exist, we silently allow this and just
> assume that it is referring to T1::func(). See https://3v4l.org/6h3PM for
> a
> more complete example.
>
> I would like to make this an error in PHP 8:
>
> > Fatal error: An alias was defined for method func(), which exists in both
> T1 and T2. Use T1::func or T2::func to resolve the ambiguity in %s
>
> As the error message indicates, the ambiguity is resolved by writing
>
>     use T1, T2 {
>         T1::func as renamedFunc;
>         // or
>         T2::func as renamedFunc;
>     }
>
> depending on which of those you actually meant.
>
> This is implemented in https://github.com/php/php-src/pull/5232.
>
> Does anyone see an issue with making this change?
>

None.

The break here doesn't seem to be wide spread, the error is clear to me,
and it has an easy remedy that may be made in PHP 7 installs today.

Thanks for fixing this!

--000000000000700095059ff55efe--