Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108820
MIME-Version: 1.0
References: <CAOWwgpkyZFQanv2XM1z+1=x-yCs3umHFQJHY_iRsoiid2G7Tuw@mail.gmail.com>
 <CAOWwgpmdHmU4jnAP14eJkoEEg_tTgBNtvSWG6qS8fLum6aq6Zg@mail.gmail.com> <CAF+90c9mNXa2OXSeMNvFVNDv1+UCV=mDXPzowOvJX-yKzH1pJA@mail.gmail.com>
In-Reply-To: <CAF+90c9mNXa2OXSeMNvFVNDv1+UCV=mDXPzowOvJX-yKzH1pJA@mail.gmail.com>
Date: Tue, 3 Mar 2020 11:09:48 +0100
Message-ID: <CAOWwgp=BRwzwqCg75CyU26iO7nKEdYKC8FdTSuN1uCtd4-E0EQ@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b4cde9059ff08177"
Subject: Re: [PHP-DEV] Re: [VOTE] Stringable
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--000000000000b4cde9059ff08177
Content-Type: text/plain; charset="UTF-8"

>
> Ironically, this broke Symfony ;)
>
> > Fatal error: Access level to class@anonymous::__toString() must be
> public (as in class Stringable) in
> /home/vsts/work/1/s/symfony/src/Symfony/Component/String/Tests/LazyStringTest.php(110)
> : eval()'d code on line 1
>
>
>
Indeed!
Fixed in https://github.com/symfony/symfony/pull/35935


But it seems that this was already a warning before:
>
> > Warning: The magic method __toString() must have public visibility and
> cannot be static in /in/3m4Za on line 4
>
> So it doesn't seem like a big issue in practice.
>

I agree :)

--000000000000b4cde9059ff08177--