Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108818
MIME-Version: 1.0
References: <CAOWwgpkyZFQanv2XM1z+1=x-yCs3umHFQJHY_iRsoiid2G7Tuw@mail.gmail.com>
 <CAOWwgpmdHmU4jnAP14eJkoEEg_tTgBNtvSWG6qS8fLum6aq6Zg@mail.gmail.com>
In-Reply-To: <CAOWwgpmdHmU4jnAP14eJkoEEg_tTgBNtvSWG6qS8fLum6aq6Zg@mail.gmail.com>
Date: Tue, 3 Mar 2020 10:54:17 +0100
Message-ID: <CAF+90c9mNXa2OXSeMNvFVNDv1+UCV=mDXPzowOvJX-yKzH1pJA@mail.gmail.com>
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000075ce65059ff04afb"
Subject: Re: [PHP-DEV] Re: [VOTE] Stringable
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000075ce65059ff04afb
Content-Type: text/plain; charset="UTF-8"

On Thu, Feb 27, 2020 at 9:49 AM Nicolas Grekas <nicolas.grekas+php@gmail.com>
wrote:

> Hello everyone,
>
> I happy to open the vote for the Stringable RFC:
> > https://wiki.php.net/rfc/stringable#vote
> >
> > The vote will stay open until 2020-02-26.
> >
>
> The proposal has been accepted with 29 "Yes" votes and 9 "No.
>
> The vote is now closed, the RFC page updated and the PR on GitHub is ready
> to merge.
>
> Thank you!
>
> Nicolas
>

Ironically, this broke Symfony ;)

> Fatal error: Access level to class@anonymous::__toString() must be public
(as in class Stringable) in
/home/vsts/work/1/s/symfony/src/Symfony/Component/String/Tests/LazyStringTest.php(110)
: eval()'d code on line 1


But it seems that this was already a warning before:

> Warning: The magic method __toString() must have public visibility and
cannot be static in /in/3m4Za on line 4

So it doesn't seem like a big issue in practice.

Nikita

--00000000000075ce65059ff04afb--