Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108783
MIME-Version: 1.0
References: <50BD013E-CF72-414C-BBC0-A7A2E45CBDDB@pmjones.io>
 <CANUQDCiP31aEqULqeGpN66ESHarKxWuXgQt_CqWeCLZc+1L-fA@mail.gmail.com>
 <5904137.fSVIMsojiJ@mcmic-probook> <CDBA02D0-07E1-4723-947C-22B403E650C0@pmjones.io>
 <CA+hqhpcOqCqXuOh3bWavJ+pZ5VVhekUO9LkKgd9c+b98VVnZSA@mail.gmail.com>
 <CAG9XoMRm2Nqjg3UbCc5=1_8m2W7qf8QRoSVk6d_qENJCKE1=9A@mail.gmail.com>
 <fcf43463-f9f7-4235-a84b-658074772ed7@www.fastmail.com> <3DDBFBA4-8D3A-46C5-9A10-B093A5E2386B@pmjones.io>
 <54493258-B52E-442A-A11D-82E1D4C7DE5E@gmail.com> <8264F6CF-AD55-41E2-9F5A-DAE8942E2B79@pmjones.io>
 <f58eea0a-6d71-be57-c0b8-abc4321cdb38@gmail.com> <1BF3D29A-04C6-4A82-9216-EAE991A38916@pmjones.io>
 <10388b3a-3402-a6dc-3837-b03d735edf46@gmail.com> <CE336F26-F119-49E6-BD7E-43B47B7F4463@pmjones.io>
 <5ec7b4a7-508b-270b-916f-0504a116196c@gmail.com> <30112AFF-38F9-44D4-9D2F-03A32019764F@pmjones.io>
 <CALKiJKqenOLuUFECKVNPu3ng70q+PGroocWZ7wN1z555Cq-3Mg@mail.gmail.com>
 <A24820E4-55B5-4F50-932B-2D9A92E8C70F@pmjones.io> <be3d4c70-5290-6ca5-a86c-dbee61931dd1@gmail.com>
 <27F45990-E3AE-4A77-85EC-A2CA1EAC73E4@pmjones.io> <CALKiJKpXQAPuRoffRpBKhgfQ63s-6XSSfWJ2epNZniv-3PFcPQ@mail.gmail.com>
 <012FB9B5-B2F6-4C2D-9F12-5F5BAC508742@pmjones.io>
In-Reply-To: <012FB9B5-B2F6-4C2D-9F12-5F5BAC508742@pmjones.io>
Date: Thu, 27 Feb 2020 16:57:03 +0000
Message-ID: <CALKiJKqLfAn0KzDukgPphpWLG0QeK_D98st+XK=ycbcehENuTw@mail.gmail.com>
To: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e65e24059f919cce"
Subject: Re: [PHP-DEV] RFC: Server-Side Request and Response Objects (v2)
From: rowan.collins@gmail.com (Rowan Tommins)

--000000000000e65e24059f919cce
Content-Type: text/plain; charset="UTF-8"

On Thu, 27 Feb 2020 at 15:55, Paul M. Jones <pmjones@pmjones.io> wrote:

> > Why not hope that ReactPHP and others will want to use this object,
> > precisely because it avoids them having to roll their own implementations
> > of things?
>
> Like I said earlier: if React ends up wanting to use ext/request, with its
> tradeoffs, of course I would think that's great. But if they want to keep
> using what they have already, with its own tradeoffs, that's great too.
>



This is one place our attitudes differ: if I was proposing something like
this to be included in every copy of PHP, I'd actively want people to use
it, and consider that a measure of success; you seem to be happy to just
put it out there and see. As such, I perhaps place greater value on
functionality that would make it more attractive, and less value on
matching what we already have.




> This is very similar to what I'm saying: to use your phrasing, I opine it
> is better to "trivially wrap" the existing PHP functionality as part of a
> separate RFC, rather than try to embed it in ServerRequest (exposed or
> otherwise).
>



That's not really the same, no. I am saying that once you have the parsing
functionality somewhere in userland, whether it's inside ServerRequest or
its own function doesn't matter, you could still use it to delete 300+
lines of code from ReactPHP.

That's a reason to add it *as soon as possible*, even if in an ideal world
it would be implemented in a slightly different place, or two different
places, or whatever.


Regards,
-- 
Rowan Tommins
[IMSoP]

--000000000000e65e24059f919cce--