Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108757
To: Nikita Popov <nikita.ppv@gmail.com>, php internals
	<internals@lists.php.net>
Thread-Topic: [PHP-DEV] Re: [RFC] token_get_all() TOKEN_AS_OBJECT mode
Thread-Index: AQHV6/SkmScWAT9IOU2mzWi+UuUzTKgsJ0e/
Date: Tue, 25 Feb 2020 18:16:44 +0000
Message-ID:
 <BYAPR05MB65350407CBA40FD65E34003DDEED0@BYAPR05MB6535.namprd05.prod.outlook.com>
References:
 <CAF+90c9TWvj9Podt3uCdf43SzwweLfjn1H3DbWnt+pSE5UKYSw@mail.gmail.com>,<CAF+90c_MShaa_-8Jtor6V6e8fJRfwxBLH67gJgmfA8BrqpiNWA@mail.gmail.com>
In-Reply-To:
 <CAF+90c_MShaa_-8Jtor6V6e8fJRfwxBLH67gJgmfA8BrqpiNWA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [J+QzQnajeHuxt+iG4sV29JaNvG+iKOvI]
x-ms-publictraffictype: Email
x-incomingheadercount: 45
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: a9799bb3-7021-418d-5f2c-08d7ba1edee7
x-ms-traffictypediagnostic: BN8NAM12HT251:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 zKxlQBcTz/PY+vXUKcrooYvEtElCpqrYAih4kwfGgtEybN8hOpkuVX8Ub3DYdayDRhowmP4BA6zMXc7cvlSNLMU3qjK08mggste/jtG/iLdERG8o1BR8ZSdfsVTpzyO7A4WkrdNIAQxEdMsj2J+BhSAIj5LkEwwoy618p9JJyKx8ENrs4qiynVAqa8yah/8ASO3f7vtooK1snwoC+idk2/gpZBEklyXtPV3A42weS5w=
x-ms-exchange-antispam-messagedata:
 7PcUQ2IP7bPs+n4n+Fhl7O+p4Q2Dd+fInuJ3QOwXhKTLGOiAg5ktDiht8aDqmm8dVPEcsPbWsMQ7tl6sa5PUytuOjhq1jBBZKPaPizpYcdrVDaUwsPIUjS19VgPKLEb8mAkG/OoQ6wdklr41GltF1w==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: a9799bb3-7021-418d-5f2c-08d7ba1edee7
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2020 18:16:44.6695
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM12HT251
Subject: Re: [PHP-DEV] Re: [RFC] token_get_all() TOKEN_AS_OBJECT mode
From: theodorejb@outlook.com (Theodore Brown)

On Tue, Feb 25, 2020 at 9:59 AM Nikita Popov <nikita.ppv@gmail.com> wrote:=
=0A=
=0A=
> On Thu, Feb 13, 2020 at 10:47 AM Nikita Popov <nikita.ppv@gmail.com> wrot=
e:=0A=
>=0A=
> > This has been discussed a while ago already, now as a proper proposal:=
=0A=
> > https://wiki.php.net/rfc/token_as_object=0A=
> >=0A=
> > An open question is whether (at least to start with) PhpToken should be=
=0A=
> > just a data container, or whether we want to add some helper methods to=
 it.=0A=
> > If this generates too much bikeshed, I'll drop methods from the proposa=
l.=0A=
>=0A=
> I think this proposal is in a pretty decent shape now, and I'd like to mo=
ve=0A=
> it to voting soon. The only remaining open question is whether we want to=
=0A=
> add any additional predefined methods. As the class can now be extended,=
=0A=
> every library can add their own methods, but there might still be value i=
n=0A=
> providing some things by default, primarily for performance reason. For=
=0A=
> example, the proposed is() method can be a good bit more efficient when=
=0A=
> implemented directly in extension code.=0A=
>=0A=
> Any feedback on this point?=0A=
=0A=
Hi Nikita,=0A=
=0A=
Thanks for this RFC. The proposed `PhpToken` class will definitely make it=
=0A=
easier to work with parsed tokens (I struggled with this when working on=0A=
the migration script for deprecated alternate array/string offset syntax).=
=0A=
=0A=
In regards to the open question of additional methods, the `getTokenName()`=
=0A=
method would be very welcome. `isIgnorable()` would also be helpful=0A=
sometimes, though I don't care much one way or another if it's added.=0A=
=0A=
But I'm really skeptical about the value of the `is($kind)` method. Code=0A=
working with tokens should know the type of value being checked (ID int,=0A=
text content, or array of one or the other), and a method that accepts=0A=
any of three types can make it harder to understand what's going on.=0A=
=0A=
For example, the proposed `isIgnorable()` method doesn't need to use=0A=
`is()`, it could just check whether the `id` property is in the array=0A=
of token constants.=0A=
=0A=
Best regards,=0A=
Theodore=0A=