Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108751
MIME-Version: 1.0
References: <CAH5C8xVYFkgyW88332ei8coMOijuynHXg3A2dL50XU4HP5Vpyw@mail.gmail.com>
 <CAKuGYLTsK2h_Yeo1vMju867hhmzyHt+GwoGStcQtiYMi2VB1tg@mail.gmail.com>
 <CAF+90c9RKf5PUQY0XHf=8QVVMw8jiJ=7eWfY5TTANEYt-a-ZAA@mail.gmail.com>
 <8545d15e-ddd5-42be-8405-09697a077234@www.fastmail.com> <CAH5C8xWgkUCAJguwnP69VqWXUaR+QtJRPMyBdv7B5vcnQjTD1g@mail.gmail.com>
 <4d9688fe-cc57-44af-903e-05f4cbb1bbcc@www.fastmail.com> <452D962A-C588-4F04-B000-479EBEA9B9DB@newclarity.net>
 <9ebc648c-39d1-45b1-9f3d-9a799c6dec93@www.fastmail.com> <01FE7634-51EC-4D94-B4A0-62C477C096EA@newclarity.net>
 <726da829-6124-4331-8b28-4d654d652b2a@www.fastmail.com>
In-Reply-To: <726da829-6124-4331-8b28-4d654d652b2a@www.fastmail.com>
Date: Tue, 25 Feb 2020 10:04:30 +0100
Message-ID: <CAH5C8xWXTWotZm5HdbRiQ0anh586xfmkZQGE_GdnKgZzY0p_Og@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000036c3c9059f62c79b"
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] Immutable/final/readonly properties
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--00000000000036c3c9059f62c79b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

 My original idea was to discuss cloning in connection with immutable
objects, - I think it's only a serious problem in that case - but we can
bring this discussion earlier of course, as readonly properties certainly
has some effect on the clonability of objects.

When I started working on implementing immutable objects, I tried to come
up with a solution for the problem of property mutation. Actually, I even
had a short discussion with Nikita about the topic. He proposed the
following syntax (which is inspired by Rust):

public function withFoo(FooT $foo): static {
    return new static { foo =3D> $foo, ...$this };
}

My idea was very similar, but it affects cloning:

$self =3D clone $this with { foo =3D> $foo, ... }

I also tried to experiment with similar solutions to the ones proposed by
Rowan, where readonly properties were unsealed after cloning (in certain
circumstances), but my general feeling was these are not the way to go. To
be honest, I also don't really like object initializers because they omit
invoking the constructor. However, "beefing up" cloning would make sense
for me.

Given, adding support for object initializers (or a special for of it), is
also a non-trivial problem - as seen in case of the previous RFC -, and
given, the absence of this construct is not a deal-breaker for readonly
properties, I still think that it would be worth to separate the two topic
(and vote separately). This way, we can keep the current proposal
self-contained and focused. If the current vote passed, I'd certainly try
to address the problem of property mutation after cloning in the immutable
object proposal.

Regards,
M=C3=A1t=C3=A9

--00000000000036c3c9059f62c79b--