Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108742
User-Agent: Cyrus-JMAP/3.1.7-947-gbed3ff6-fmstable-20200220v2
Mime-Version: 1.0
Message-ID: <be51109d-e38a-4c90-9ea5-f783b5524390@www.fastmail.com>
In-Reply-To: <72DB7A36-CB51-4901-AF63-6B0B46664C44@benramsey.com>
References: 
 <CAEo3Y-f1tP8AOVu=k_3ZXcDBJz_1XdpXUcUjQ6S+B=iq_3U1LA@mail.gmail.com>
 <B252A123-F8DC-47FD-8E8F-65482BA37BB2@benramsey.com>
 <CAEo3Y-dT8GwfW1mu6Wq+M=sqbu2KA-dBNQeQ2jP171dss1fSgQ@mail.gmail.com>
 <72DB7A36-CB51-4901-AF63-6B0B46664C44@benramsey.com>
Date: Mon, 24 Feb 2020 14:10:20 -0600
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] str_contains
From: larry@garfieldtech.com ("Larry Garfield")

On Mon, Feb 24, 2020, at 10:56 AM, Ben Ramsey wrote:
> > On Feb 24, 2020, at 10:52, Philipp Tanlak <philipp.tanlak@gmail.com>=
 wrote:
> >=20
> >> Ben Ramsey <ben@benramsey.com> schrieb am Mo. 24. Feb. 2020 um 17:2=
1:
> >> > On Feb 23, 2020, at 03:12, Philipp Tanlak <philipp.tanlak@gmail.c=
om> wrote:
> >> >
> >> > Hey PHP Devs!
> >> >
> >> > Since the RFC to str_contains is now almost a week old and most o=
f the
> >> > discussion happened in the initial discussion/proposal thread, I =
wasn't
> >> > sure if everyone has seen it. Therefore I'd like to create this n=
ew email
> >> > thread with the correct label for RFC discussions, before we open=
 up the
> >> > RFC for voting in approximately a week from now.
> >> >
> >> > If there is any feedback or something you'd like to discuss, feel=
 free to
> >> > leave it here.
> >> >
> >> > Link to RFC: https://wiki.php.net/rfc/str_contains
> >> >
> >> > Regards
> >> > Philipp
> >>=20
> >>=20
> >> Just so I=E2=80=99m clear on the functionality here, is this essent=
ially the same behavior as the following?
> >>=20
> >>=20
> >>     strpos($haystack, $needle) !=3D=3D false
> >>=20
> >>=20
> >> And the purpose is primarily for a better developer experience by r=
educing confusion through providing a dedicated function for this behavi=
or?
> >=20
> > Yes, this is correct.
>=20
>=20
> As an effort to improve developer experience, I=E2=80=99m on board wit=
h this. I=20
> think it make sense to add this.
>=20
> Cheers,
> Ben

I fully support this as well.  It's a common source of subtle bugs, and =
a minor change to the standard library can eliminate a major PHP WTF.

--Larry Garfield