Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108695
MIME-Version: 1.0
References: <CA+41xTXZBziaWG6Sp3XmYU-6+4ou3Dp-qksER5HsE-qGpr_ZRg@mail.gmail.com>
 <CAEsg9X0TctW+5m=u_Uj2+qHiAxJs2=94anX-SiRjoUAGWEo6YQ@mail.gmail.com>
 <CA+41xTUdZB1boybkTL043j8i9gaw6GMqGGYxuKpAGWZ4-B2Adw@mail.gmail.com>
 <C8E0BB63-CCCA-4DDB-8F04-C688BDE274A5@newclarity.net> <CALKiJKoj4Bc0aXLOCN4xXEMsPenAYKpM30bqOfkxG7p6YNzakg@mail.gmail.com>
 <1586E4D0-B327-46A1-92C3-F9E2F89E33DB@newclarity.net> <CALKiJKqqiWUKceMvaAC3Z0AH28YrE=crvuiHq0OFdgxqJk+tdQ@mail.gmail.com>
In-Reply-To: <CALKiJKqqiWUKceMvaAC3Z0AH28YrE=crvuiHq0OFdgxqJk+tdQ@mail.gmail.com>
Date: Thu, 20 Feb 2020 10:11:59 +0100
Message-ID: <CAF+90c-RqvkqRS8hES2wR2Aw6wfaUcOE_r_EeNNVHVtLTVbE7A@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000000dd2e9059efe4d4a"
Subject: Re: [PHP-DEV] New PCRE function
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000000dd2e9059efe4d4a
Content-Type: text/plain; charset="UTF-8"

On Wed, Feb 19, 2020 at 6:36 PM Rowan Tommins <rowan.collins@gmail.com>
wrote:

> On Wed, 19 Feb 2020 at 17:15, Mike Schinkel <mike@newclarity.net> wrote:
>
> > From https://github.com/golang/go/wiki/CodeReviewComments#error-strings
> >
> > "Error strings should not be capitalized (unless beginning with proper
> > nouns or acronyms) or end with punctuation, since they are usually
> printed
> > following other context. That is, use fmt.Errorf("something bad") not
> > fmt.Errorf("Something bad"), so that log.Printf("Reading %s: %v",
> filename,
> > err) formats without a spurious capital letter mid-message. This does not
> > apply to logging, which is implicitly line-oriented and not combined
> inside
> > other messages."
> >
>
>
> Thanks, I can see the reasoning, although I'm not sure I agree with it.
>
> If you're only showing it to a programmer, worrying about the grammar of a
> capital letter after a colon seems needlessly pedantic. If you're showing
> it to end-users, you should probably be thinking about i18n anyway, and can
> load your own English translations (and user-friendly summaries) for
> whatever context you want to show them in.
>

FWIW, it is our established stance that all error messages must be
capitalized. Lower-case first character is only permitted if it is part of
a function name, or similar cases.

Regards,
Nikita

--0000000000000dd2e9059efe4d4a--