Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108679
MIME-Version: 1.0
References: <CA+41xTXZBziaWG6Sp3XmYU-6+4ou3Dp-qksER5HsE-qGpr_ZRg@mail.gmail.com>
 <CAEsg9X0TctW+5m=u_Uj2+qHiAxJs2=94anX-SiRjoUAGWEo6YQ@mail.gmail.com>
 <CA+41xTUdZB1boybkTL043j8i9gaw6GMqGGYxuKpAGWZ4-B2Adw@mail.gmail.com>
 <C8E0BB63-CCCA-4DDB-8F04-C688BDE274A5@newclarity.net> <CALKiJKoj4Bc0aXLOCN4xXEMsPenAYKpM30bqOfkxG7p6YNzakg@mail.gmail.com>
 <1586E4D0-B327-46A1-92C3-F9E2F89E33DB@newclarity.net>
In-Reply-To: <1586E4D0-B327-46A1-92C3-F9E2F89E33DB@newclarity.net>
Date: Wed, 19 Feb 2020 18:27:07 +0100
Message-ID: <CAFPFaMJzjY6nPcgb7Bu=fByMOp1p_=UDUmWV6a12d+673UCNzw@mail.gmail.com>
To: Mike Schinkel <mike@newclarity.net>
Cc: Rowan Tommins <rowan.collins@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000008fa6f059ef11a14"
Subject: Re: [PHP-DEV] New PCRE function
From: george.banyard@gmail.com ("G. P. B.")

--00000000000008fa6f059ef11a14
Content-Type: text/plain; charset="UTF-8"

On Wed, 19 Feb 2020 at 18:15, Mike Schinkel <mike@newclarity.net> wrote:

> > On Feb 19, 2020, at 12:10 PM, Rowan Tommins <rowan.collins@gmail.com>
> wrote:
> >
> >>> On Wed, Feb 19, 2020 at 4:20 PM David Rodrigues <
> david.proweb@gmail.com>
> >>> wrote:
> >>>
> >>>> Maybe you can set all this messages as lowercase? That way we can use
> it
> >>>> more easily.
> >>
> >
> >
> >
> >> On Wed, 19 Feb 2020 at 16:50, Mike Schinkel <mike@newclarity.net>
> wrote:
> >>
> >> I am however influenced by Go which specifies that all error messages
> >> should be lowercased for the exact reason that David suggests.
> >>
> >
> >
> > Like Nico, I'm not sure what lowercase is easier for. Can either of you
> > expand on the reasoning / use case?
>
>
> From https://github.com/golang/go/wiki/CodeReviewComments#error-strings
>
> "Error strings should not be capitalized (unless beginning with proper
> nouns or acronyms) or end with punctuation, since they are usually printed
> following other context. That is, use fmt.Errorf("something bad") not
> fmt.Errorf("Something bad"), so that log.Printf("Reading %s: %v", filename,
> err) formats without a spurious capital letter mid-message. This does not
> apply to logging, which is implicitly line-oriented and not combined inside
> other messages."
>
>
> -Mike
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php


But that's Golang's policy, so either we change all error messages to be
lower case or we keep it consistent with what PHP currently does.
Moreover, I'm not sure I see a massive benefit in having it in lowercase
(especially just one random function which behaves not like others)

Best regards

George P. Banyard

--00000000000008fa6f059ef11a14--