Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108678
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
In-Reply-To: <CALKiJKoj4Bc0aXLOCN4xXEMsPenAYKpM30bqOfkxG7p6YNzakg@mail.gmail.com>
Date: Wed, 19 Feb 2020 12:15:15 -0500
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <1586E4D0-B327-46A1-92C3-F9E2F89E33DB@newclarity.net>
References: <CA+41xTXZBziaWG6Sp3XmYU-6+4ou3Dp-qksER5HsE-qGpr_ZRg@mail.gmail.com>
 <CAEsg9X0TctW+5m=u_Uj2+qHiAxJs2=94anX-SiRjoUAGWEo6YQ@mail.gmail.com>
 <CA+41xTUdZB1boybkTL043j8i9gaw6GMqGGYxuKpAGWZ4-B2Adw@mail.gmail.com>
 <C8E0BB63-CCCA-4DDB-8F04-C688BDE274A5@newclarity.net>
 <CALKiJKoj4Bc0aXLOCN4xXEMsPenAYKpM30bqOfkxG7p6YNzakg@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Subject: Re: [PHP-DEV] New PCRE function
From: mike@newclarity.net (Mike Schinkel)

> On Feb 19, 2020, at 12:10 PM, Rowan Tommins <rowan.collins@gmail.com> =
wrote:
>=20
>>> On Wed, Feb 19, 2020 at 4:20 PM David Rodrigues =
<david.proweb@gmail.com>
>>> wrote:
>>>=20
>>>> Maybe you can set all this messages as lowercase? That way we can =
use it
>>>> more easily.
>>=20
>=20
>=20
>=20
>> On Wed, 19 Feb 2020 at 16:50, Mike Schinkel <mike@newclarity.net> =
wrote:
>>=20
>> I am however influenced by Go which specifies that all error messages
>> should be lowercased for the exact reason that David suggests.
>>=20
>=20
>=20
> Like Nico, I'm not sure what lowercase is easier for. Can either of =
you
> expand on the reasoning / use case?


=46rom =
https://github.com/golang/go/wiki/CodeReviewComments#error-strings

"Error strings should not be capitalized (unless beginning with proper =
nouns or acronyms) or end with punctuation, since they are usually =
printed following other context. That is, use fmt.Errorf("something =
bad") not fmt.Errorf("Something bad"), so that log.Printf("Reading %s: =
%v", filename, err) formats without a spurious capital letter =
mid-message. This does not apply to logging, which is implicitly =
line-oriented and not combined inside other messages."


-Mike=