Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108674
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
In-Reply-To: <CA+41xTUdZB1boybkTL043j8i9gaw6GMqGGYxuKpAGWZ4-B2Adw@mail.gmail.com>
Date: Wed, 19 Feb 2020 11:50:20 -0500
Cc: David Rodrigues <david.proweb@gmail.com>,
 PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <C8E0BB63-CCCA-4DDB-8F04-C688BDE274A5@newclarity.net>
References: <CA+41xTXZBziaWG6Sp3XmYU-6+4ou3Dp-qksER5HsE-qGpr_ZRg@mail.gmail.com>
 <CAEsg9X0TctW+5m=u_Uj2+qHiAxJs2=94anX-SiRjoUAGWEo6YQ@mail.gmail.com>
 <CA+41xTUdZB1boybkTL043j8i9gaw6GMqGGYxuKpAGWZ4-B2Adw@mail.gmail.com>
To: Nico Oelgart <nicoswd@gmail.com>
Subject: Re: [PHP-DEV] New PCRE function
From: mike@newclarity.net (Mike Schinkel)

> On Feb 19, 2020, at 10:33 AM, Nico Oelgart <nicoswd@gmail.com> wrote:
>=20
> On Wed, Feb 19, 2020 at 4:20 PM David Rodrigues =
<david.proweb@gmail.com>
> wrote:
>=20
>> Maybe you can set all this messages as lowercase? That way we can use =
it
>> more easily. If we need the first letter in capital letters we can =
use
>> `ucfirst()`, because the opposite is more complicated (a =
`strtolower()`
>> would "break" the "JIT" message, for example).
>>=20
>=20
> Hi David!
>=20
> I'm not sure how this would be more useful, plus all other built-in
> functions like
> json_last_error_msg() don't return all-lowercase strings either.
>=20
> I'd prefer it to be consistent with the rest of functions.


I agree with David.  Lowercase is best. =20

I am however influenced by Go which specifies that all error messages =
should be lowercased for the exact reason that David suggests.

Consistency is nice, but I would argue it is not great when it means not =
being able to adopt emerging better practices.

#jmtcw

-Mike=20=