Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108657
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
In-Reply-To: <2868575.XpRCUmUyJT@mcmic-probook>
Date: Tue, 18 Feb 2020 07:33:37 -0600
Cc: internals@lists.php.net
Content-Transfer-Encoding: quoted-printable
Message-ID: <142F6B38-0524-4311-9350-26AD8D7DE137@pmjones.io>
References: <50BD013E-CF72-414C-BBC0-A7A2E45CBDDB@pmjones.io>
 <CANUQDCiP31aEqULqeGpN66ESHarKxWuXgQt_CqWeCLZc+1L-fA@mail.gmail.com>
 <3E805205-A559-44D7-98FA-960E92FE5E6E@pmjones.io>
 <2868575.XpRCUmUyJT@mcmic-probook>
To: =?utf-8?Q?C=C3=B4me_Chilliet?= <come.chilliet@fusiondirectory.org>
Subject: Re: [PHP-DEV] RFC: Server-Side Request and Response Objects (v2)
From: pmjones@pmjones.io ("Paul M. Jones")

Hi C=C3=B4me,

> On Feb 18, 2020, at 03:24, C=C3=B4me Chilliet =
<come.chilliet@fusiondirectory.org> wrote:
>=20
> Le jeudi 13 f=C3=A9vrier 2020, 09:16:49 CET Paul M. Jones a =C3=A9crit =
:
>=20
>> Yeah, naming is one of the hard problems. I considered $query as an =
alternative property name for $get, but in the end, the `$_GET =3D> =
$get` symmetry was too great to ignore. If others here feel that $query =
is a better name for `$_GET` than $get, I will submit to consensus on =
that point.
>=20
> query is definitely better than get.

Excellent.


> Regarding post, I=E2=80=99m fine with body, parsedBody and input.
>=20
> I get the idea of input to mimic php://input, but if I understand =
things correctly, php://input is raw body, while $request->post is =
parsed body, so naming them alike might actually cause confusion?

Might, might not. I don't think there is any "good" name here, only =
names that are less-bad than others.


> I still do not understand this.
> echo adds content to the response, it does not replace it.
> So the equivalent function should be $response->addContent.
>=20
> I would expect $response->setContent to replace the content.

Ah, I see what you are getting at now ...


> Can you explicit behavior for this:
>=20
>  $response->setContent("a\n");
>  $response->setContent("b\n");
>  $responseSender->send($response);
>=20
> Compared to
>=20
>  echo "a\n";
>  echo "b\n";

... the output would be "b\n". As you say, setContent() replaces =
whatever content is already in the ServerResponse. While the comparison =
for a single echo is accurate, the comparison for multiple echoes would =
be:

    $content =3D "a\n";
    $content .=3D "b\n";
    $response->setContent($content);
    $responseSender->send($content);

Does that help to clarify?


--=20
Paul M. Jones
pmjones@pmjones.io
http://paul-m-jones.com

Modernizing Legacy Applications in PHP
https://leanpub.com/mlaphp

Solving the N+1 Problem in PHP
https://leanpub.com/sn1php