Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108652
To: internals@lists.php.net
Date: Tue, 18 Feb 2020 10:24:52 +0100
Message-ID: <2868575.XpRCUmUyJT@mcmic-probook>
Organization: FusionDirectory
User-Agent: KMail/5.2.3 (Linux/4.9.0-12-amd64; KDE/5.28.0; x86_64; ; )
In-Reply-To: <3E805205-A559-44D7-98FA-960E92FE5E6E@pmjones.io>
References: <50BD013E-CF72-414C-BBC0-A7A2E45CBDDB@pmjones.io> <CANUQDCiP31aEqULqeGpN66ESHarKxWuXgQt_CqWeCLZc+1L-fA@mail.gmail.com> <3E805205-A559-44D7-98FA-960E92FE5E6E@pmjones.io>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] RFC: Server-Side Request and Response Objects (v2)
From: come.chilliet@fusiondirectory.org (=?ISO-8859-1?Q?C=F4me?= Chilliet)

Le jeudi 13 f=C3=A9vrier 2020, 09:16:49 CET Paul M. Jones a =C3=A9crit :
> Yeah, naming is one of the hard problems. I considered $query as an alter=
native property name for $get, but in the end, the `$_GET =3D> $get` symmet=
ry was too great to ignore. If others here feel that $query is a better nam=
e for `$_GET` than $get, I will submit to consensus on that point.

query is definitely better than get.

Regarding post, I=E2=80=99m fine with body, parsedBody and input.

I get the idea of input to mimic php://input, but if I understand things co=
rrectly, php://input is raw body, while $request->post is parsed body, so n=
aming them alike might actually cause confusion?

> > Given 'echo $content; =3D> $response->setContent($content);', shouldn't
> > this rather be something like `addContent()`?
>=20
> That looks like poor describing on my part in the RFC. It is more true to=
 say that these are equivalent:
>=20
>     echo $content;
>    =20
>     // =3D>
>    =20
>     $response->setContent($content);
>     $responseSender->send($response);
>=20
> I will try to make that more apparent in the RFC.

I still do not understand this.
echo adds content to the response, it does not replace it.
So the equivalent function should be $response->addContent.

I would expect $response->setContent to replace the content.

Can you explicit behavior for this:

  $response->setContent("a\n");
  $response->setContent("b\n");
  $responseSender->send($response);

Compared to

  echo "a\n";
  echo "b\n";

=2D-=20
C=C3=B4me Chilliet
=46usionDirectory - https://www.fusiondirectory.org