Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108600
MIME-Version: 1.0
References: <CAF+90c9TWvj9Podt3uCdf43SzwweLfjn1H3DbWnt+pSE5UKYSw@mail.gmail.com>
 <CAESVnVoe68=AWByg_qV5XUcV9W1RqksB=pp_OkNjThDSqjA7Aw@mail.gmail.com>
 <CAF+90c-dKy+zi9_TxNHzZrQAvFe6WW+9UPA_7VS9AqXQtWLE-g@mail.gmail.com> <CALKiJKqfzZcticDL-FS+6F9VLV+EaOo++SeA-oZ9M2SfBKsbMg@mail.gmail.com>
In-Reply-To: <CALKiJKqfzZcticDL-FS+6F9VLV+EaOo++SeA-oZ9M2SfBKsbMg@mail.gmail.com>
Date: Sat, 15 Feb 2020 16:47:54 +0100
Message-ID: <CAF+90c8ZGJ--s5ZJUiYhKGgkYE4-tf-0VsDZCGG3_8myfKUD1Q@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c6495b059e9f3f12"
Subject: Re: [PHP-DEV] [RFC] token_get_all() TOKEN_AS_OBJECT mode
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000c6495b059e9f3f12
Content-Type: text/plain; charset="UTF-8"

On Fri, Feb 14, 2020 at 7:30 PM Rowan Tommins <rowan.collins@gmail.com>
wrote:

> On Fri, 14 Feb 2020 at 16:33, Nikita Popov <nikita.ppv@gmail.com> wrote:
>
> > This constructor will initialize the corresponding properties. Now, the
> > behavior that would make most sense to me (if extension of the class is
> > allowed) is that MyPhpToken::getAll() is going to create the new tokens
> > based on "new MyPhpToken($id, $text, $line, $pos)". If we mark the
> > constructor final, then we could hardcode the construction behavior of
> the
> > base class without introducing any kind of weird rules, it would be just
> > the usual language semantics.
> >
>
>
> It's worth noting that this is how ext/simplexml works: the $class
> parameter of simplexml_load_string and simplexml_load_file must be the name
> of a class that inherits from SimpleXMLElement, and an instance of that
> class will be constructed for each element of the document. The constructor
> of SimpleXMLElement is final, so the internal initialisation logic doesn't
> have to actually call it, it can just initialise the private state
> directly.
>

Thanks for pointing that out, I wasn't aware that SimpleXMLElement is
already using this pattern. Given that, I've updated the RFC to go with
that option now.

Nikita

--000000000000c6495b059e9f3f12--