Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108588
MIME-Version: 1.0
References: <CAF+90c9TWvj9Podt3uCdf43SzwweLfjn1H3DbWnt+pSE5UKYSw@mail.gmail.com>
 <CAESVnVoe68=AWByg_qV5XUcV9W1RqksB=pp_OkNjThDSqjA7Aw@mail.gmail.com> <CAF+90c-dKy+zi9_TxNHzZrQAvFe6WW+9UPA_7VS9AqXQtWLE-g@mail.gmail.com>
In-Reply-To: <CAF+90c-dKy+zi9_TxNHzZrQAvFe6WW+9UPA_7VS9AqXQtWLE-g@mail.gmail.com>
Date: Fri, 14 Feb 2020 18:30:19 +0000
Message-ID: <CALKiJKqfzZcticDL-FS+6F9VLV+EaOo++SeA-oZ9M2SfBKsbMg@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000078027a059e8d66bf"
Subject: Re: [PHP-DEV] [RFC] token_get_all() TOKEN_AS_OBJECT mode
From: rowan.collins@gmail.com (Rowan Tommins)

--00000000000078027a059e8d66bf
Content-Type: text/plain; charset="UTF-8"

On Fri, 14 Feb 2020 at 16:33, Nikita Popov <nikita.ppv@gmail.com> wrote:

> This constructor will initialize the corresponding properties. Now, the
> behavior that would make most sense to me (if extension of the class is
> allowed) is that MyPhpToken::getAll() is going to create the new tokens
> based on "new MyPhpToken($id, $text, $line, $pos)". If we mark the
> constructor final, then we could hardcode the construction behavior of the
> base class without introducing any kind of weird rules, it would be just
> the usual language semantics.
>


It's worth noting that this is how ext/simplexml works: the $class
parameter of simplexml_load_string and simplexml_load_file must be the name
of a class that inherits from SimpleXMLElement, and an instance of that
class will be constructed for each element of the document. The constructor
of SimpleXMLElement is final, so the internal initialisation logic doesn't
have to actually call it, it can just initialise the private state directly.

Regards,
-- 
Rowan Tommins
[IMSoP]

--00000000000078027a059e8d66bf--