Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108581
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
In-Reply-To: <5904137.fSVIMsojiJ@mcmic-probook>
Date: Fri, 14 Feb 2020 09:47:25 -0600
Cc: internals@lists.php.net
Content-Transfer-Encoding: quoted-printable
Message-ID: <CDBA02D0-07E1-4723-947C-22B403E650C0@pmjones.io>
References: <50BD013E-CF72-414C-BBC0-A7A2E45CBDDB@pmjones.io>
 <CANUQDCiP31aEqULqeGpN66ESHarKxWuXgQt_CqWeCLZc+1L-fA@mail.gmail.com>
 <5904137.fSVIMsojiJ@mcmic-probook>
To: =?utf-8?Q?C=C3=B4me_Chilliet?= <come.chilliet@fusiondirectory.org>,
 Niklas Keller <me@kelunik.com>
Subject: Re: [PHP-DEV] RFC: Server-Side Request and Response Objects (v2)
From: pmjones@pmjones.io ("Paul M. Jones")

Hi C=C3=B4me & Niklas,

> On Feb 13, 2020, at 04:52, C=C3=B4me Chilliet =
<come.chilliet@fusiondirectory.org> wrote:
>=20
> Le mercredi 12 f=C3=A9vrier 2020, 19:20:56 CET Niklas Keller a =C3=A9cri=
t :
>=20
>> Naming
>>=20
>> I think we shouldn't take over the naming of the super globals, e.g.
>> $_GET really contains the query parameters and has nothing to do with
>> GET or POST, so $request->getQueryParameter(...) would be a better
>> name.
>=20
> I think this remark is really on point.
> GET and POST are HTTP methods and not ways of passing data. You can =
have query parameters on any request, and you can have POST data with a =
lot of other HTTP methods, as is commonly used in REST APIs.

Your comments on naming are well-made.

While working on the implementation, we tried out $query instead of =
$get, on exactly the premise that you state: i.e., that `$_GET` holds =
the query parameters, and has nothing to do with the GET method. But in =
the end, we settled on mapping more directly from `$_GET` =3D> `$get`, =
and `$_POST =3D> $post`.

Having said that, we are willing to revisit that naming decision if =
there's support for doing so. Perhaps:

- rename $get to $query, populating it from `$globals['_GET']`, on the =
basis stated above
- rename $post to $input, populating it from `$globals['_POST']`, on the =
basis that it typically relates to the parsed form of php://input

Your (and/or anyone else's) thoughts on that?


--=20
Paul M. Jones
pmjones@pmjones.io
http://paul-m-jones.com

Modernizing Legacy Applications in PHP
https://leanpub.com/mlaphp

Solving the N+1 Problem in PHP
https://leanpub.com/sn1php