Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108576
MIME-Version: 1.0
References: <CAF+90c9TWvj9Podt3uCdf43SzwweLfjn1H3DbWnt+pSE5UKYSw@mail.gmail.com>
 <CAESVnVoe68=AWByg_qV5XUcV9W1RqksB=pp_OkNjThDSqjA7Aw@mail.gmail.com>
In-Reply-To: <CAESVnVoe68=AWByg_qV5XUcV9W1RqksB=pp_OkNjThDSqjA7Aw@mail.gmail.com>
Date: Fri, 14 Feb 2020 14:44:10 +0100
Message-ID: <CADyq6sJeDNGQWc8n32-43MhWAnUPiSFQgRjxR+6eGGDe+-6NFA@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002ce103059e89677c"
Subject: Re: [PHP-DEV] [RFC] token_get_all() TOKEN_AS_OBJECT mode
From: ocramius@gmail.com (Marco Pivetta)

--0000000000002ce103059e89677c
Content-Type: text/plain; charset="UTF-8"

On Fri, Feb 14, 2020 at 2:38 PM Sara Golemon <pollita@php.net> wrote:

> Thanks for picking it up, and I agree with your response to Larry.  As nice
> as it would be to lazy iterate, the scanner is just in NO shape to tolerate
> reentering userspace and potentially reinvoking the scanner before the
> first run through is done.
>

If this is the current state, maybe it would suffice to declare the return
type as `iterable`, and return a strict (fully populated) structure in a
first implementation, later to be changed to an iterator, if applicable?

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--0000000000002ce103059e89677c--