Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108563
MIME-Version: 1.0
References: <CAEo3Y-dTioEqVPW-7ewxsTWf6HRzp0F0TT+LqVZ3gBWB6MvreA@mail.gmail.com>
In-Reply-To: <CAEo3Y-dTioEqVPW-7ewxsTWf6HRzp0F0TT+LqVZ3gBWB6MvreA@mail.gmail.com>
Date: Fri, 14 Feb 2020 09:44:48 +0000
Message-ID: <CAJvSBVN=7FkPg7JQDiomr+1ocgb3FPW=4OxCcJAbknwKgqP9Kg@mail.gmail.com>
To: Philipp Tanlak <philipp.tanlak@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008c86be059e861034"
Subject: Re: [PHP-DEV] Proposal for a new basic function: str_contains
From: phpmailinglists@gmail.com (Peter Bowyer)

--0000000000008c86be059e861034
Content-Type: text/plain; charset="UTF-8"

On Fri, 14 Feb 2020 at 09:18, Philipp Tanlak <philipp.tanlak@gmail.com>
wrote:

> I would like to propose the new basic function: str_contains.
>
> The proposed signature for this function follows the conventions of other
> signatures of string functions and should look like this:
>
>     str_contains(string $haystack, string $needle): bool
>
> What are your opinions on this proposal?
>

In principle, yes. There are a couple of considerations first, like how you
plan to handle case-insensitive matches; and previous discussions for this
and the wider context of related string functions:
https://externals.io/message/106162
https://externals.io/message/100142
https://externals.io/message/94787
https://wiki.php.net/rfc/add_str_begin_and_end_functions

Peter

--0000000000008c86be059e861034--