Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108559
MIME-Version: 1.0
References: <CAD5P3=JwFK03L-DWJYaa0dbBj1chbef_=K-vyawLNeoAz7dHjA@mail.gmail.com>
 <CALSrLtYm+TSEwo+05JC6LXrQsfzb32pQ24Y7gDUmm-7+NwYi8w@mail.gmail.com>
 <CAOWwgpm43=hoCvsskq2qyhB3yVxntLAYC8hQjQwd9dnvQ=GKkg@mail.gmail.com>
 <CAD5P3=L8bQ4bp5i5f=SdOP-=Wmn6TSj6+4Jzw76WRwJ=89evtw@mail.gmail.com>
 <CAF+90c-myY2NeKcaTRH3zDcwxRC95RhKnm1MPTGN68WUq4RPAA@mail.gmail.com>
 <CAPKYkKy-NwDmpN_5Zet8Oz9JLVzu11PmODP6byBYuJry3TUvbg@mail.gmail.com>
 <CE981907-0CDD-421F-BC01-1B3F0E95B199@newclarity.net> <ebc970d9-8c70-9563-1792-fd8c7ef67f2f@gmail.com>
 <DE2D0FCB-4C39-43F4-B6B6-B5796271EB0E@newclarity.net> <10FCCCED-B8AE-4394-91B3-0FEB448E2398@gmail.com>
 <D368D433-A2AE-4C05-9341-A6F0502BF454@newclarity.net> <CALKiJKrHKiY0-4=ihES5Uw4OUinAmyNRaiNqQrX-x3Gj74mWDQ@mail.gmail.com>
 <2C404984-AD76-4CDF-8E1A-04DF8EF024DD@newclarity.net> <0BE8FC1E-A9BF-4A2A-9CA5-59BEE1245632@gmail.com>
 <938FDD44-1F60-4FE1-B0F1-E70284F5F2D2@newclarity.net>
In-Reply-To: <938FDD44-1F60-4FE1-B0F1-E70284F5F2D2@newclarity.net>
Date: Fri, 14 Feb 2020 08:04:48 +0100
Message-ID: <CAD5P3=+aqkObrcob0MEEaMNN_U=M=+2+tnfNX1KKE2znYdvuMA@mail.gmail.com>
To: Mike Schinkel <mike@newclarity.net>
Cc: Rowan Tommins <rowan.collins@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e458bc059e83d218"
Subject: Re: [PHP-DEV] [RFC]
From: manuelcanga@gmail.com (Manuel Canga)

--000000000000e458bc059e83d218
Content-Type: text/plain; charset="UTF-8"

On Fri, 14 Feb 2020 at 01:39, Mike Schinkel <mike@newclarity.net> wrote:

> > On Feb 13, 2020, at 7:24 PM, Rowan Tommins <rowan.collins@gmail.com>
> wrote:
> >
> > An idea I had earlier which might solve some of them is if what was
> returned was not a normal Closure instance, but a new class like
> FunctionReference. It could then "remember" the name of the function
> wrapped, and implement __toString, Serializable, etc. It could inherit from
> Closure, so instanceof checks would work, and bindTo would return a normal
> Closure. I'm sure there's downsides I haven't thought of yet, but I thought
> I'd throw the idea into the mix.
>
> I thought about that too, and mentioned it yesterday in a reply[1] to you
> on this list.
>
> Here is the link to the Gist with the hypothetical code using such a
> concept:
>
> - https://gist.github.com/mikeschinkel/78684d708358e1d101e319c7a2fdef9c
>
> -Mike
>
>
> [1] https://www.mail-archive.com/internals@lists.php.net/msg100719.html
>
>
Maybe, bettern fn:  * fn(callable $to_clsoure ): *closure ?

I know fn is used in arrow functions. However, for that same reason fn is
the most convenient.

Using dik examples( by the way, they are brilliant ):

$result = Stats::of($string)
    ->analyze(fn(normalizeNewlines))
     ->analyze(fn(readingLevel))
     ->analyze(fn(countStats))
     ->analyze(fn($synonymSuggester, 'analyze'))
     ->analyze(fn(WordCouter::class, 'analyze'))
     ->analyze(fn($s) => wordDistribution($s, 3))

Returning to ::function again and with a modified example of dik( again ):

Now is:

result = Stats::of($string)
    ->analyze('\Stats\Analyzer\normalizeNewlines')
    ->analyze('\Stats\Readings\readingLevel')
    ->analyze('\Stats\Parser\countStats')
    ->analyze(fn($s) => \Stats\Analyzer\wordDistribution($s, 3));

Could be:
use function Stats\Analyzer\normalizeNewlines;
use function \Stats\Readings\readingLevel;
use function \Stats\Parser\countStats;

result = Stats::of($string)
    ->analyze(normalizeNewlines::function)
    ->analyze(readingLevel::function)
    ->analyze(countStats::function )
    ->analyze(fn($s) => \Stats\Analyzer\wordDistribution($s, 3));

Maybe '::function' is something long, however it wiil be autocompleted by
editors and, moreover, nowadays function is a reserved keyword.  Could we
use "normalizeNewlines::name", but in this case: normalizeNewlines is
function or class ?, because in this case could be "normalizeNewlines" a
class and "name" a constant of class.

Rowan put me in an awkward situation with [MyClass::class, method::function
] however, in this case, could be simply MyClass::class, 'method' ].
Because method don't need be used with namespace. ::function could be
documented with advice of being used  with name of functions. Because
::function is also useful in array:

$filters = [ normalizeNewlines::function, readingLevel::function,
countStats::function
]
$content = Stats::of($string);
foreach($filters as $filter) $filter($content);

Regards

--000000000000e458bc059e83d218--