Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108541
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
In-Reply-To: <4E050173-8FCC-4770-BCD2-22DB22E24EFC@php.net>
Date: Thu, 13 Feb 2020 10:08:07 -0600
Cc: PHP Internals List <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <7D960D1A-B348-4D96-A81F-CB79F31862D2@pmjones.io>
References: <50BD013E-CF72-414C-BBC0-A7A2E45CBDDB@pmjones.io>
 <3efc8ed3-61a8-dad8-dd1f-207217589eba@allenjb.me.uk>
 <ADC3F146-EB49-463D-8FB7-323C35E98C71@pmjones.io>
 <4E050173-8FCC-4770-BCD2-22DB22E24EFC@php.net>
To: Ruud Boon <ruudboon@php.net>
Subject: Re: [PHP-DEV] RFC: Server-Side Request and Response Objects (v2)
From: pmjones@pmjones.io ("Paul M. Jones")

Hi Ruud,


> On Feb 13, 2020, at 00:45, Ruud Boon <ruudboon@php.net> wrote:
>=20
> Hi!
>=20
> I really like this RFC.=20

Glad to hear it!


> In the the RFC I see that $content will return  php://input using =
file_get_contents on the fly. Can we add the possibility to get a =
reference to the stream as well?

By "get a reference" I presume you mean "an open file handle" (a la =
`return fopen('php://input', 'rb')`).

In which case: maybe? I can see where that would be useful for extremely =
large request bodies in a memory-constrained environment.

But the question becomes: is that needed frequently-enough across a =
wide-enough range of PHP developers to warrant inclusion in this RFC? I =
don't recall seeing any userland implementation from my research provide =
such a thing. That makes me think it's a comparatively infrequent need.

If many others disagree with that assessment, I'm happy to entertain the =
possibility of adding something like it to ServerRequest.


--=20
Paul M. Jones
pmjones@pmjones.io
http://paul-m-jones.com

Modernizing Legacy Applications in PHP
https://leanpub.com/mlaphp

Solving the N+1 Problem in PHP
https://leanpub.com/sn1php