Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108535
Date: Thu, 13 Feb 2020 14:23:20 +0300 (EET)
Reply-To: "Ekin B." <me@ekins.space>
To: =?UTF-8?Q?C=C3=B4me_Chilliet?= <come.chilliet@fusiondirectory.org>,
	internals@lists.php.net
Message-ID: <876634340.168763.1581593000586@privateemail.com>
In-Reply-To: <5904137.fSVIMsojiJ@mcmic-probook>
References: <50BD013E-CF72-414C-BBC0-A7A2E45CBDDB@pmjones.io>
 <CANUQDCiP31aEqULqeGpN66ESHarKxWuXgQt_CqWeCLZc+1L-fA@mail.gmail.com>
 <5904137.fSVIMsojiJ@mcmic-probook>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Importance: Normal
Subject: Re: [PHP-DEV] RFC: Server-Side Request and Response Objects (v2)
From: me@ekins.space ("Ekin B.")

Hi all,

> On February 13, 2020 1:52 PM C=C3=B4me Chilliet <come.chilliet@fusiondire=
ctory.org> wrote:
>=20
> =20
> Le mercredi 12 f=C3=A9vrier 2020, 19:20:56 CET Niklas Keller a =C3=A9crit=
 :
> > Naming
> >=20
> > I think we shouldn't take over the naming of the super globals, e.g.
> > $_GET really contains the query parameters and has nothing to do with
> > GET or POST, so $request->getQueryParameter(...) would be a better
> > name.
>=20
> I think this remark is really on point.
> GET and POST are HTTP methods and not ways of passing data. You can have =
query parameters on any request, and you can have POST data with a lot of o=
ther HTTP methods, as is commonly used in REST APIs.
>=20
> I do not like the name getQueryParameter at first sight, but I do not lik=
e get() and post() for getting values from $_GET and $_POST.
> I would expect a method named post to actually post something, not just g=
et a value.
>=20
> --=20
> C=C3=B4me Chilliet
> FusionDirectory - https://www.fusiondirectory.org
>=20
> --

I agree that this is indeed on point.
Personally I would like $request->getQueryParameter() and $request->getBody=
() over $request->get() and $request->post().
In the former case you are asking for the parameters in the query string (q=
uery component of the URI) and the latter is to get the request body. These=
 method names make it very clear what you're asking for.

What kind of bothers me in general about this RFC is that... we are talking=
 about Request and Response and these are standard HTTP components, yet the=
 RFC is about providing wrappers for existing global PHP variables and func=
tions. It does not try to model these components as they are in their stand=
ard, nor aim to do so.

This is why I believe it's better to leave it to userland implementations. =
Besides the fact that they are widely adopted, they attempt to follow the s=
pecification they are providing.=20

Regards,
Ekin H. Bayar=20
https://ekins.space=20
https://heap.space