Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108495
MIME-Version: 1.0
References: <CAD5P3=JwFK03L-DWJYaa0dbBj1chbef_=K-vyawLNeoAz7dHjA@mail.gmail.com>
 <CALSrLtYm+TSEwo+05JC6LXrQsfzb32pQ24Y7gDUmm-7+NwYi8w@mail.gmail.com>
 <CAOWwgpm43=hoCvsskq2qyhB3yVxntLAYC8hQjQwd9dnvQ=GKkg@mail.gmail.com>
 <CA+kxMuQgdS+N90PsPXPrzgOaebVS1OJUinJ=T+61PaMXcO+-GQ@mail.gmail.com> <CAD5P3=+j+b+1zT7GUpagV9OOx95m50Nn05_m5fkrVzjL1pPaOA@mail.gmail.com>
In-Reply-To: <CAD5P3=+j+b+1zT7GUpagV9OOx95m50Nn05_m5fkrVzjL1pPaOA@mail.gmail.com>
Date: Tue, 11 Feb 2020 20:01:57 +0100
Message-ID: <CABdc3Wq-En2Uo33Yo1_ojMM4EY0gr7DOM6nw5VXOf_K_eZkY6g@mail.gmail.com>
To: Manuel Canga <manuelcanga@gmail.com>
Cc: Dan Ackroyd <danack@basereality.com>, Nicolas Grekas <nicolas.grekas+php@gmail.com>, 
	Diogo Galvao <diogo86@gmail.com>, PHP Internals List <internals@lists.php.net>, 
	Nikita Popov <nikita.ppv@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000250b57059e517e43"
Subject: Re: [PHP-DEV] [RFC]
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Brzuchalski?=)

--000000000000250b57059e517e43
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

wt., 11 lut 2020, 18:42 u=C5=BCytkownik Manuel Canga <manuelcanga@gmail.com=
>
napisa=C5=82:

> On Tue, 11 Feb 2020 at 17:49, Dan Ackroyd <Danack@basereality.com> wrote:
> >
> > Nicolas Grekas wrote:
> > > I wish this would return a Closure instead, making $foo::function the
> > > equivalent of Closure::fromCallable($foo).
> >
> > I didn't include the following in that RFC, because I thought it would
> > be too controversial, but I think it's worth considering a new syntax
> > for this.
> >
> > Given the code:
> >
> > function foo();
> > class Zoq {
> >     public function Fot() {}
> >     public static function Pik() {}
> > }
> > $obj =3D new Zoq();
> >
> >
> > Then these:
> >
> > $(foo);
> > $($obj, Fot);
> > $(Zoq, Fot);
> >
> > Would be equivalent to:
> >
> > Closure::fromCallable('foo');
> > Closure::fromCallable([$obj, 'Fot']);
> > Closure::fromCallable('Zoq::Fot'); or Closure::fromCallable(['Zoq',
> 'Fot']);
> >
> > Or similar.
> >
> > The justification for having a dedicated syntax is that I think
> > readability is quite important in code, and it's reasonably common for
> > me to have quite long lists of 'callables'.
> >
> > [Bar::class, foo1::function],
> > [Bar::class, foo2::function],
> > [Bar::class, foo3::function],
> > [Bar::class, foo4::function]
> >
> > vs
> >
> > $(Bar, foo1),
> > $(Bar, foo2),
> > $(Bar, foo3),
> > $(Bar, foo4)
> >
> > The latter is far easier to read for me.
> >
> > Nikita Popov wrote:
> > > This would circumvent all the issues outlined in
> > > https://wiki.php.net/rfc/consistent_callables.
> >
> > Probably there would still be some issues with some of the weird stuff
> > happening internally in SPL related code where the deep horrors
> > rest...but we can leave them alone...and they might not wake.
> >
> > cheers
> > Dan
> > Ack
>
> Other option:
>
> Closure::fromCallable('foo');
> Closure::fromCallable([$obj, 'Fot']);
> Closure::fromCallable('Zoq::Fot'); or Closure::fromCallable(['Zoq',
> 'Fot']);
>
> to
>
> <Foo>
> <$foo, Fot>
> <Zoq::Fot>
> <Zoq,'Fot>
>
> E.g:
>
> array_map(<strlen>, $array);
> array_map(<I18n, Translate>, $array);
>
> Do you like ?
>

That reminds me an old draft RFC https://wiki.php.net/rfc/short-closures
where I thought curly braces can be used to create closure from syntax
nearly the same as invoking but without parentheses.

That way we can provide clear intent - I mean if whatever is around: curly
braces or $ with parentheses IMHO it should be consistent with call like
format. For example:

$(strlen) or {strlen} for Closure::fromCallable('foo')

$($foo->Fot) or {$foo->Fot} for Closure::fromCallable([$obj, 'Fot'])

$(Zoq::Fot) or {Zoq::Fot} for Closure::fromCallable('Zoq::Fot')

Etc. The same inside like a call but wrapped in something and with no
parentheses part.

Cheers,
--
Micha=C5=82 Brzuchalski

>

--000000000000250b57059e517e43--