Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108460
MIME-Version: 1.0
References: <CAN+C6bVeO4nU_3egiwhM0MML9NUJJB4oYgWVUo_bhJRPKUVpPQ@mail.gmail.com>
 <14a19b55-b7fa-5879-90cf-fc285c141ae8@allenjb.me.uk>
In-Reply-To: <14a19b55-b7fa-5879-90cf-fc285c141ae8@allenjb.me.uk>
Date: Tue, 11 Feb 2020 11:18:28 +0000
Message-ID: <CAJvSBVPsuNbP7-qfZ1myDv+E8QF+itzBm09x3DRkWi4FsSmvDw@mail.gmail.com>
To: AllenJB <php.lists@allenjb.me.uk>
Cc: Tom Van Looy <tom@ctors.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000003681c059e4b06d2"
Subject: Re: [PHP-DEV] [RFC] deprecate md5_file and sha1_file
From: phpmailinglists@gmail.com (Peter Bowyer)

--00000000000003681c059e4b06d2
Content-Type: text/plain; charset="UTF-8"

On Tue, 11 Feb 2020 at 09:34, AllenJB <php.lists@allenjb.me.uk> wrote:

> If you want to change the way developers think about hashing when
> writing PHP, I would start with the documentation rather than
> deprecating functions which are essentially aliases and are highly
> likely used all over the place in cases where they do exactly what
> people want.
>

I agree. It isn't wrong to use MD5 or SHA1 in the right situation (or even
CRC32). The documentation can tell people when they can use these
algorithms, and when they must not think about using them. Mark them in the
documentation as "RECOMMENDED DO NOT USE" and guide people away.

Peter

--00000000000003681c059e4b06d2--