Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108451
MIME-Version: 1.0
References: <CAN+C6bVeO4nU_3egiwhM0MML9NUJJB4oYgWVUo_bhJRPKUVpPQ@mail.gmail.com>
 <285058d8-572e-b5c4-51d2-4db28213ee01@gmail.com>
In-Reply-To: <285058d8-572e-b5c4-51d2-4db28213ee01@gmail.com>
Reply-To: Tom Van Looy <tom@ctors.net>
Date: Tue, 11 Feb 2020 07:25:04 +0100
Message-ID: <CAN+C6bWrewS9gxofLVqhNfQxnVy00Pod862=vxgJBc4VChqTcw@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000003e8372059e46ebed"
Subject: Re: [PHP-DEV] [RFC] deprecate md5_file and sha1_file
From: internals@lists.php.net ("Tom Van Looy via internals")

--0000000000003e8372059e46ebed
Content-Type: text/plain; charset="UTF-8"

On Tue, 11 Feb 2020, 06:59 Stanislav Malyshev, <smalyshev@gmail.com> wrote:

> Hi!
>
> > I suggest to deprecated the functions md5_file() and sha1_file(). This
> will
>
> Not sure what's the point of it. SHA1 and MD5 didn't change. The
> recommendations for their usage has changed, but we generally don't use
> deprecation warnings to improve users' code and recommend them how to
> structure their code better.


Yes that was my point with "modern php". The recommendation changed.

It seems like most people in this discussion like to keep the functions. I
didn't expect that.

Thanks for the feedback and the arguments all!

Tom

--0000000000003e8372059e46ebed--