Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:108449 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 38416 invoked from network); 11 Feb 2020 07:45:23 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 11 Feb 2020 07:45:23 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 8367218053A for ; Mon, 10 Feb 2020 21:59:12 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 10 Feb 2020 21:59:11 -0800 (PST) Received: by mail-pl1-f175.google.com with SMTP id j7so3824773plt.1 for ; Mon, 10 Feb 2020 21:59:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zwP9x9ZGTVHhNDomvb/RevZpkKxzL7H/OqyNIz+/B/A=; b=tQIbyncrh5V8kosiWJTrQ1d8R8QuMwju/AmjqrYEF83sVT25fI++Mp/R84uZf5N4ND NcI4pWkPhlGskQDKO11/yU5X+qSnmZYGXOZG8F2EZed2U/6kOR77EoeqxtKNmLpCfGzX dv5eWdKJLKEuEo2ev+lMly+mGDBZ6Bef16nZ2d+edxjDNS8S8Rbde+VYAEFkWybiREbg XYGYzwpWQa/j0BJB2q10rx09VD7WsXTQgY5DgkUGtqK0HBFQDpJXUihuBT3mmUj42Z6d +4u5fsnc0sgJmV0O/rwyiOFsq/5uEOhL2xvogzxQoZft0cjqjQduOencCRwqH6lyTE7b 8jxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zwP9x9ZGTVHhNDomvb/RevZpkKxzL7H/OqyNIz+/B/A=; b=RIr1Lu86dng0PiB48Bi4Dh6XBd+vyypDDkJDbSkHXUo37yTqGF0Onah6B8gKaKuBBG 95UKXYTuTOoQTFUYBjbM2r9aYpk9BI28H93f+kPWDHEGkOCRcXErf2tIIpeQqvL6yl3L Cqp8b3dDzlGuu7napDqp9DDB9nvvkijFrjvIihB8A1LEkRrB8fsSVA7sA63Od6t5JMAs 1+rKm2X6TerRvts5APNRz9WDCMacngdS5d8SdZB4z0+lVPrBp+ciMOLztnK9f8MWaAqr TJ7f/VBoz3aCyz6mq2nxHhdV5148ZhFgJpd4ashffvxn2/GnzN6CeiMdXJY5DrCcMtrI 4w0g== X-Gm-Message-State: APjAAAWBAwEwxquXD4zrr2Q9ix/huMFVQoPGq3eHlnapZySFLrQWuqm2 RBYFmrWBmy2NiHPADfKe5N38cNdi8g== X-Google-Smtp-Source: APXvYqzAY1hrriJGFGVjPYCpuscEByfsIqsnwPNSdcmB4DheeDHhTTCbE+ElG/jtDVbpdksnEFM8mg== X-Received: by 2002:a17:902:8ec9:: with SMTP id x9mr16483077plo.182.1581400747959; Mon, 10 Feb 2020 21:59:07 -0800 (PST) Received: from Stas-Mac.local (ec2-34-209-88-149.us-west-2.compute.amazonaws.com. [34.209.88.149]) by smtp.gmail.com with ESMTPSA id h62sm2330460pfg.95.2020.02.10.21.59.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2020 21:59:06 -0800 (PST) To: Tom Van Looy , PHP internals References: Autocrypt: addr=smalyshev@gmail.com; prefer-encrypt=mutual; keydata= xsJuBE9mqaARCACFSqcGmNunkjQQu3X+yXnTmFeEkvM4JXZTOBdR8aEevNGmmFEfyvjaDjWi 9hcwp4E/lYtC+P7VsVjM1OSX9eq0jC/lGL0ZyRXek+mNy0n5H1NSuTpf9Y18LMqhc4G+RU+L cNiZ9K0DJuOOvNLPxW7OHZguxb3wdKPXNVa2jyRfJAKm2uaJJMT1mTmFT9a0Q8SKr+mUrrJk uG0H2o6SzrKt8Wwoint1eh67zVsJaJtQFchnEZnlawIcqP2yC4nLGR3MkubowxoEBYCZet18 aHVVRbvpG2Qtob8Lu5xrsGbmXymTkHTdpvkfcJFADa8MzOL90zOxXwbGfbIZOlh5En8jAQCX lfnx2eQL3BSW/6XANa51dbWiEp1d1BAkpGKtZvlk0Qf+M9WAi+9aXMe3xP5krxtgnRNUf2WN 6Zdy2MxL1RRJCFbytLhl0ronC49BsGYVGshdEH8xhBbiIOJKuVZ/DTl9bEm7P9c7CC7iJyVC khUAhouH6xzZQNLR+RU+QebYzXypVfl99Qk7EdMmr/WAZCHLuvanyqepC5EBsa3VnAfQemSN oBeGBKWWLiOsPjvS72+y1z4RUMAfXHn4l/sFMt8zt7/74AmJPwZquV41p4mPO12V4+xPyc6R sB84sfsk2QVivU8w8AkvGQeYjXoz7Iwao95+fWteVzZ36KRQvUckP8pGjHlDXnHxJ0HI1I/k OBZSjwRwUf0dd73y6erPhbLk+gf+NdI3H9KGJBzG5/rVyWKwUeQ9d5ud4jTJRkQGvAP5pg76 vEa9dogbpe4W5Z+0BfbiJSnQmQWSHiZddj/t33ptbup44Ck6ZTgdlmFYMLF1hR47PIZTDKER EuKYGci/vq8snZvEJP9YCw/TtiHcMdrMKcY/+Lp8lQO0GHLPB9glVhnC0db6l1Xpg1CMI8/R ozBMcij30EgATggC/y2zbiqAFoS9FN9nXPbe4phStqABEyeZ+nXudt7PUYTjVgcrqo8bHZCi sBobWC7OnKyUzxVxzUeuPkIfmZuzkLaMw2McQdvwwsNvQ0DzaLP30c1Xsm/7EIYJcOWpzlVJ 5QrdmE0/Bc0yU3RhbmlzbGF2IE1hbHlzaGV2IChQSFAga2V5KSA8c21hbHlzaGV2QGdtYWls LmNvbT7CegQTEQgAIgUCT2aqtAIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQL3lW vF2gS12XMwD9HuRIolSwIK77u8EY461y2u6sbX36n5/uo/LDQuxoi3sA/0MvpnvzOhv9Iufv vsZEj3E7i3h+iD5648YMwfTFCij+zsFNBE9mqaAQCADfZPMpjZkkGZj3BY/7ApoLq4mwqzbh +CpLXwNn20tFNvSXfb8RdeXvVEb7Scx+W9qYpiaun2iXJgCVH8fgpZpR856ulT1q6uCG++CX ubEvip/eJkZl93/84h04KQJwsgOrAh0Om3OePRn8Pr+++0LNS0EL8uX/YHeTOGOnnmTqYTey SBVFdov6L4mepddfjekicKQqhL7mZh/xuq29JijT0uNNX8v4vDWQDu5dlAcdd+uB3gcXMD/P ginD11zp+6wtrWCm/+yBqpvDwXQX5PGUnwvbRfl7Ay3MmwmoXiecZMg0dwTSc7e0lhB4HGRH ZdBMJB4rHUVGdzqujK/ctOvrAAMFB/0Utb76Qe6sCMlHxVAmeE/fbo7Pi05btZ/x01r67dHf aMSP0riCKJ7M0OW+jAXtu9+z/BVnYisW67WWfxl2cS5tZDgiHgJARXWUOO72+sScHP8KQmTl 1z16gyKbwY3SmyBkwcpOL35nhUWNLy93syPoY6sZUTikr2bZYukHDQ33XBPs4e6MbWKfsa9q aVmnlOF3k5UqChjutfHaEa4Q7VP4wBIpphHBi9MI16oJIzzBPbGl2uoedjwiZ6QeQZnSuOVY ZxU2d3lRA8PrtfFN1VSlpEm/VcAvtieHUYWHN0wOu+cp3Slr5XJVNjTjJhl28SlinMME54mK AGf2Ldr/dRwXwmEEGBEIAAkFAk9mqaACGwwACgkQL3lWvF2gS126EQD/VVd3FgjLKglClRQP zdfU847tqDK4zJjbmRv5vLLwoE0A+wbrQs7jVGU3NrS0AIl5vUmewpp2BKzSkepy23nWmejw Message-ID: <285058d8-572e-b5c4-51d2-4db28213ee01@gmail.com> Date: Mon, 10 Feb 2020 21:59:05 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] deprecate md5_file and sha1_file From: smalyshev@gmail.com (Stanislav Malyshev) Hi! > I suggest to deprecated the functions md5_file() and sha1_file(). This will Not sure what's the point of it. SHA1 and MD5 didn't change. The recommendations for their usage has changed, but we generally don't use deprecation warnings to improve users' code and recommend them how to structure their code better. Deprecation is usually for functions that are unsupported (and going to go away) or not having any non-broken uses anymore. We have crc32() function which is much less secure than md5 for check-summing obviously, and we don't deprecate it because of that. I don't think we should use deprecations for that purpose. > Carrying around these two dedicated functions seems a bit too much for a > modern PHP. What do you think? There's zero effort expended on "carrying around" these functions, and I don't see why it's "too much" for "modern PHP"? What changed in "modern PHP" that suddenly brought forward the need to minimize the number of existing functions? I don't see any reason for that. On the contrary, deprecating it causes work for people that legitimately use these functions, and makes them either turn off deprecation warnings (unsafe and may lead to real deprecations pass unnoticed) or work around this. I don't think it is beneficial. -- Stas Malyshev smalyshev@gmail.com