Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108448
MIME-Version: 1.0
References: <CAN+C6bVeO4nU_3egiwhM0MML9NUJJB4oYgWVUo_bhJRPKUVpPQ@mail.gmail.com>
 <5e41dae0.1c69fb81.1cb50.6c01SMTPIN_ADDED_MISSING@mx.google.com>
In-Reply-To: <5e41dae0.1c69fb81.1cb50.6c01SMTPIN_ADDED_MISSING@mx.google.com>
Reply-To: Tom Van Looy <tom@ctors.net>
Date: Tue, 11 Feb 2020 00:04:26 +0100
Message-ID: <CAN+C6bWOsPTmeA_dmHa+a+6Uv8hBYGj8w_DuVtMcvJoM_ubkfw@mail.gmail.com>
To: Mark Randall <marandall@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000070956a059e40c36b"
Subject: Re: [PHP-DEV] Re: [RFC] deprecate md5_file and sha1_file
From: internals@lists.php.net ("Tom Van Looy via internals")

--00000000000070956a059e40c36b
Content-Type: text/plain; charset="UTF-8"

On Mon, 10 Feb 2020, 23:36 Mark Randall, <marandall@php.net> wrote:

> On 10/02/2020 21:49, Tom Van Looy via internals wrote:
> > I suggest to deprecated the functions md5_file() and sha1_file(). This
> will
> > make people think about upgrading to a better alternative.
>
> It won't.
>

You can lead a horse to water but you can't make it drink.

If this is explained in the upgrade guide, that's all we can do.

I would limit the deprecation to these two functions. Not the entire
algo's, because indeed that's not going to happen.

I give you another case.

What if a new user finds only these two functions and starts using them
because a sha512_file() etc. does not exist?

If the functions are deprecated at least that would be explained in the
docs.

Tom

>

--00000000000070956a059e40c36b--