Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108446
MIME-Version: 1.0
References: <CAN+C6bVeO4nU_3egiwhM0MML9NUJJB4oYgWVUo_bhJRPKUVpPQ@mail.gmail.com>
 <5e41dadc.1c69fb81.a6614.77f0SMTPIN_ADDED_MISSING@mx.google.com>
In-Reply-To: <5e41dadc.1c69fb81.a6614.77f0SMTPIN_ADDED_MISSING@mx.google.com>
Date: Mon, 10 Feb 2020 17:42:05 -0500
Message-ID: <CAPKYkKyDn3X0m6-=RmqiZth5Zn2KBc=7GmFjG_o66E4k7paPDw@mail.gmail.com>
To: Mark Randall <marandall@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008702b2059e4073d0"
Subject: Re: [PHP-DEV] Re: [RFC] deprecate md5_file and sha1_file
From: chasepeeler@gmail.com (Chase Peeler)

--0000000000008702b2059e4073d0
Content-Type: text/plain; charset="UTF-8"

On Mon, Feb 10, 2020 at 5:36 PM Mark Randall <marandall@php.net> wrote:

> On 10/02/2020 21:49, Tom Van Looy via internals wrote:
> > I suggest to deprecated the functions md5_file() and sha1_file(). This
> will
> > make people think about upgrading to a better alternative.
>
> It won't.
>
> At best it will make people switch to the hash function. At worst people
> will not upgrade.
>
> If people are using the existing md5 / sha1 algorithms, chances are it's
> because they're actually wanting to get a hash to compare to something
> that has already been stored.
>
> There's not much point in deprecating the algorithm if we don't
> eventually plan to remove it, and there is an exactly zero percent
> chance of it being removed at any point in the next 50 years.
>
> Mark Randall
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
Why? What does deprecating those two functions do to make PHP a better
language? It doesn't add any new features. It doesn't fix any security
issues. It doesn't even take away the ability to perform the functionality
that they provide, since it still exists in the hash_file function.

If you don't like the function, then don't use it.



-- 
Chase Peeler
chasepeeler@gmail.com

--0000000000008702b2059e4073d0--