Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108442
MIME-Version: 1.0
References: <CAN+C6bVeO4nU_3egiwhM0MML9NUJJB4oYgWVUo_bhJRPKUVpPQ@mail.gmail.com>
In-Reply-To: <CAN+C6bVeO4nU_3egiwhM0MML9NUJJB4oYgWVUo_bhJRPKUVpPQ@mail.gmail.com>
Date: Mon, 10 Feb 2020 13:52:42 -0800
Message-ID: <CADbOR2i3Jq25rVPwvYtRN=mJ+rrJH40LhyvzpBx89t1tob6_Ag@mail.gmail.com>
To: Tom Van Looy <tom@ctors.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e63bc2059e3fc2f4"
Subject: Re: [PHP-DEV] [RFC] deprecate md5_file and sha1_file
From: zardozrocks@gmail.com (j adams)

--000000000000e63bc2059e3fc2f4
Content-Type: text/plain; charset="UTF-8"

I disagree. While MD5 and SHA1 might not be suitable for modern
cryptographic operations, these functions might be needed for legacy
situations -- e.g., munging through old data.


On Mon, Feb 10, 2020 at 1:50 PM Tom Van Looy via internals <
internals@lists.php.net> wrote:

> Hi
>
> While in some environments the use of MD5 and SHA1 are still acceptable for
> some use cases like file integrity verification etc. the use of these
> algorithms should be discouraged and not be your choice when developing new
> applications.
>
> I suggest to deprecated the functions md5_file() and sha1_file(). This will
> make people think about upgrading to a better alternative. If you still
> need this functionality you can always switch to the hash_file() function.
>
> Carrying around these two dedicated functions seems a bit too much for a
> modern PHP. What do you think?
>
> My feeling was that this is a no brainer. Should I open an RFC for this?
>
> Kind regards,
>
> Tom Van Looy
>

--000000000000e63bc2059e3fc2f4--