Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108441
MIME-Version: 1.0
Reply-To: Tom Van Looy <tom@ctors.net>
Date: Mon, 10 Feb 2020 22:49:51 +0100
Message-ID: <CAN+C6bVeO4nU_3egiwhM0MML9NUJJB4oYgWVUo_bhJRPKUVpPQ@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b086dd059e3fb838"
Subject: [RFC] deprecate md5_file and sha1_file
From: internals@lists.php.net ("Tom Van Looy via internals")

--000000000000b086dd059e3fb838
Content-Type: text/plain; charset="UTF-8"

Hi

While in some environments the use of MD5 and SHA1 are still acceptable for
some use cases like file integrity verification etc. the use of these
algorithms should be discouraged and not be your choice when developing new
applications.

I suggest to deprecated the functions md5_file() and sha1_file(). This will
make people think about upgrading to a better alternative. If you still
need this functionality you can always switch to the hash_file() function.

Carrying around these two dedicated functions seems a bit too much for a
modern PHP. What do you think?

My feeling was that this is a no brainer. Should I open an RFC for this?

Kind regards,

Tom Van Looy

--000000000000b086dd059e3fb838--