Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108424
MIME-Version: 1.0
References: <CAF+90c88t4YkHwHyM5dW9NWgCzxz0jM3Oz6e3i=2K7e6ELiaGQ@mail.gmail.com>
 <5e3c7253.1c69fb81.c5725.860bSMTPIN_ADDED_MISSING@mx.google.com> <CAF+90c8UfCff+QmOxT6CrguKgm-cmqmpc6rGx6Td8Y65RQqW4g@mail.gmail.com>
In-Reply-To: <CAF+90c8UfCff+QmOxT6CrguKgm-cmqmpc6rGx6Td8Y65RQqW4g@mail.gmail.com>
Date: Fri, 7 Feb 2020 14:40:20 +0100
Message-ID: <CAOWwgpnj5Dmg-6XNFzQxOMV+wzao460k4mFrfzpUe+=b2L8uBA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Andrea Faulds <ajf@ajf.me>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009b91ac059dfc8834"
Subject: Re: [PHP-DEV] Re: Changing the generated name for anon classes
From: nicolas.grekas@gmail.com (Nicolas Grekas)

--0000000000009b91ac059dfc8834
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Le ven. 7 f=C3=A9vr. 2020 =C3=A0 14:36, Nikita Popov <nikita.ppv@gmail.com>=
 a =C3=A9crit :

> On Thu, Feb 6, 2020 at 9:08 PM Andrea Faulds <ajf@ajf.me> wrote:
>
>> Hi,
>>
>> Nikita Popov wrote:
>> > Hi internals,
>> >
>> > Based on a suggestion by Nicolas Grekas,
>> > https://github.com/php/php-src/pull/5153 changes the generated name fo=
r
>> > anonymous classes to include the name of the parent class or first
>> > interface. So instead of just class@anonymous, you'll see something
>> like
>> > EventHandler@anonymous in error messages, for example.
>> >
>> > There's a minor BC break here, for code checking for a "class@anonymou=
s
>> "
>> > prefix, which should be easy to rectify by checking for "@anonymous"
>> > instead.
>> >
>> > What do people think about doing this change?
>> >
>> > Regards,
>> > Nikita
>> >
>>
>> Perhaps it would make sense to include the namespace used by the code
>> which defines/instantiates the class? That might make it easier, when
>> looking at a mysterious anonymous class using var_dump() deep in a big
>> project perhaps, to find out where it came from.
>>
>
> That would be a possible alternative. This is similar to what we do for
> closures.
>
> As we need the generated name to be reasonably concise, we can only do on=
e
> or the other though. I don't know which one is more useful... Maybe Nicol=
as
> wants to chime in.
>


The proposed names are the most useful from my experience, take e.g. these
lines, found in the same class:

throw new class() implements ServerExceptionInterface {...};
[...]
throw new class() implements ClientExceptionInterface {...};

The debugging experience is better mentioning ServerExceptionInterface or
ClientExceptionInterface than the namespace of the surrounding class. The
file + line info will fo straight to this surrounding class also, so the
proposal maximizes the amount of useful info from my experience.

Nicolas

--0000000000009b91ac059dfc8834--