Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108413
MIME-Version: 1.0
References: <CAF+90c88t4YkHwHyM5dW9NWgCzxz0jM3Oz6e3i=2K7e6ELiaGQ@mail.gmail.com>
In-Reply-To: <CAF+90c88t4YkHwHyM5dW9NWgCzxz0jM3Oz6e3i=2K7e6ELiaGQ@mail.gmail.com>
Date: Thu, 6 Feb 2020 14:44:57 +0100
Message-ID: <CADq_CxoOjEVdyGMgJJFjdnxeQmHwFo27UWERc6CmXNb7y-uG_A@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002d63cc059de87b1c"
Subject: Re: [PHP-DEV] Changing the generated name for anon classes
From: robin@kingsquare.nl ("Kingsquare.nl - Robin Speekenbrink")

--0000000000002d63cc059de87b1c
Content-Type: text/plain; charset="UTF-8"

Nikita,

Just to chime in here: would it be wise to add an interface instead? (this
would automatically be added by the engine) so that the consumer of a
generated class could *really* know based on the interface that it's a
generated anonymous class instead of string type checking the classname?
Relying on some interface seems te be more future proof than just
changing the string to look up ;)

Keep up the good work!

Regards
Robin

Op do 6 feb. 2020 om 12:21 schreef Nikita Popov <nikita.ppv@gmail.com>:

> Hi internals,
>
> Based on a suggestion by Nicolas Grekas,
> https://github.com/php/php-src/pull/5153 changes the generated name for
> anonymous classes to include the name of the parent class or first
> interface. So instead of just class@anonymous, you'll see something like
> EventHandler@anonymous in error messages, for example.
>
> There's a minor BC break here, for code checking for a "class@anonymous"
> prefix, which should be easy to rectify by checking for "@anonymous"
> instead.
>
> What do people think about doing this change?
>
> Regards,
> Nikita
>

--0000000000002d63cc059de87b1c--