Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108405
MIME-Version: 1.0
In-Reply-To: <CAF+90c9hdNN-dQRmDRZ6uPS5uLbEcY-JFZ4rwwpORMBo_KGqZg@mail.gmail.com>
References: <CAF+90c-YHBKfMG1foO6HZWeyD5h2WnQFN5fmXG9V2sZ_uFRW-A@mail.gmail.com>
 <5e24c6ec.1c69fb81.1d93b.aafcSMTPIN_ADDED_MISSING@mx.google.com> <CAF+90c9hdNN-dQRmDRZ6uPS5uLbEcY-JFZ4rwwpORMBo_KGqZg@mail.gmail.com>
Date: Wed, 5 Feb 2020 13:15:56 +0100
Message-ID: <CAC5V6ghza4JnY08j9vb7UCkR6=S6XqDX0mLnnAHQM5Bdqjz19w@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Andrea Faulds <ajf@ajf.me>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000006d8899059dd31e9a"
Subject: Re: [PHP-DEV] Warn when declaring required parameter after optional one
From: guilliam.xavier@gmail.com (Guilliam Xavier)

--0000000000006d8899059dd31e9a
Content-Type: text/plain; charset="UTF-8"

Hi,

On Wednesday, February 5, 2020, Nikita Popov <nikita.ppv@gmail.com> wrote:
>
>
> I like this idea and have updated the pull request to ignore the "Type
> $param = null" case, so the deprecation should now just catch the
> "definitely" incorrect signatures.
>
> So to summarize the current state:
>
> function test($foo = "bar", $baz) {}
> // Deprecated: Required parameter $baz follows optional parameter $foo
>
> function test(Abc $foo = null, $baz) {}
> // No warnings, works fine!
>
> With that adjustment made, are there any further concerns about this
> change?


Can you please just clarify which of the following will emit a deprecation?

function f1($a = null, $b) {}
function f2(A $a = null, $b) {}
function f3(?A $a = null, $b) {}

(I think f1 will, f2 won't, but f3?)

Thanks


>
> Regards,
> Nikita
>


-- 
Guilliam Xavier

--0000000000006d8899059dd31e9a--