Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108404
MIME-Version: 1.0
References: <CAF+90c-YHBKfMG1foO6HZWeyD5h2WnQFN5fmXG9V2sZ_uFRW-A@mail.gmail.com>
 <5e24c6ec.1c69fb81.1d93b.aafcSMTPIN_ADDED_MISSING@mx.google.com>
In-Reply-To: <5e24c6ec.1c69fb81.1d93b.aafcSMTPIN_ADDED_MISSING@mx.google.com>
Date: Wed, 5 Feb 2020 10:49:38 +0100
Message-ID: <CAF+90c9hdNN-dQRmDRZ6uPS5uLbEcY-JFZ4rwwpORMBo_KGqZg@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000001b0be8059dd11450"
Subject: Re: [PHP-DEV] Re: Warn when declaring required parameter after
 optional one
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000001b0be8059dd11450
Content-Type: text/plain; charset="UTF-8"

On Sun, Jan 19, 2020 at 10:15 PM Andrea Faulds <ajf@ajf.me> wrote:

> Hi Nikita,
>
> Nikita Popov wrote:
> >
> > Since nullable types have been available since PHP 7.1, having a required
> > parameter after an optional one is increasingly likely a bug rather than
> an
> > intentional workaround, so I think it would be good to throw a warning
> for
> > this case.
> >
> Wouldn't it be trivial to special-case `= NULL` here to not cause a
> warning, or to cause an E_NOTICE instead of an E_WARNING? That would
> make this less annoying for old code. I don't know whether I think this
> worth doing or not, I just want to point out the possibility.
>

I like this idea and have updated the pull request to ignore the "Type
$param = null" case, so the deprecation should now just catch the
"definitely" incorrect signatures.

So to summarize the current state:

function test($foo = "bar", $baz) {}
// Deprecated: Required parameter $baz follows optional parameter $foo

function test(Abc $foo = null, $baz) {}
// No warnings, works fine!

With that adjustment made, are there any further concerns about this change?

Regards,
Nikita

--0000000000001b0be8059dd11450--