Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108386
MIME-Version: 1.0
References: <D5ACEB01-4E1E-407A-8441-D8C6E0D36CCA@gmail.com>
 <CADyq6s+SPJj_aGhg044XbW4KdRNYrV=bAxGX6ioMpihpg0E2SA@mail.gmail.com>
 <CAEPJdun=b1mtuBbAZMGAHR8Ya2Jg0xuc07Nq34TvZr75uu3=8Q@mail.gmail.com>
 <CADyq6s+YPBSpO7WASVCEsT6rdQVQ8u1z6+ZL-042X_2ZKG_MMA@mail.gmail.com> <5077f0f4-4532-5131-0c8b-8b38017d66b5@aimeos.com>
In-Reply-To: <5077f0f4-4532-5131-0c8b-8b38017d66b5@aimeos.com>
Date: Tue, 4 Feb 2020 15:23:35 +0100
Message-ID: <CADyq6sJR-EvM7gDQgSXbeGHF-3-m+6hDN8wyd5+5T4+aB=FoGg@mail.gmail.com>
To: "Aimeos | Norbert Sendetzky" <norbert@aimeos.com>
Cc: Benjamin Eberlei <kontakt@beberlei.de>, Steven Wade <stevenwadejr@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000df08f3059dc0c9b3"
Subject: Re: [PHP-DEV] [RFC - discussion] __toArray()
From: ocramius@gmail.com (Marco Pivetta)

--000000000000df08f3059dc0c9b3
Content-Type: text/plain; charset="UTF-8"

On Tue, Feb 4, 2020, 14:50 Aimeos | Norbert Sendetzky <norbert@aimeos.com>
wrote:

> Am 04.02.20 um 14:43 schrieb Marco Pivetta:
> >> I think we can't classify it as BC break, because no existing code
> >> implements __toArray at the moment, and hence it will not fail when this
> >> feature is introduced and code gets upgraded to newer versions.
> >
> > It is a BC break because it changes the semantic of `(array) $object`:
> the
> > operation is no longer stable between two versions of the language.
>
> It wouldn't be a BC breaking change if `(array) $object` works like
> before when __toArray() isn't implemented by an object. As nobody should
> have implemented __toArray() because it's a reserved name for magic
> methods, we should be fine.
>

The operation in question, when seen by its signature, is:

(array) :: object FieldTypes -> Map String FieldTypes

The proposed RFC changes this to (pardon the weird union type: my type-fu
is not that advanced):

(array) :: (FieldTypes|IO ToArrayTypes a) => object a -> Map String a

This changes the return type of a very much pure function (even makes it
non-pure: fun), and is a very, very, very clear BC break.

>

--000000000000df08f3059dc0c9b3--