Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108380
MIME-Version: 1.0
References: <D5ACEB01-4E1E-407A-8441-D8C6E0D36CCA@gmail.com>
 <CAEPJdukNJ1QKswOH4eJ8=-ghtRiy8HCM+-uROz-2AOzrbTTsiQ@mail.gmail.com> <516080A1-D777-49BD-A4A1-9978C2D558CB@gmail.com>
In-Reply-To: <516080A1-D777-49BD-A4A1-9978C2D558CB@gmail.com>
Date: Tue, 4 Feb 2020 14:43:21 +0100
Message-ID: <CAEPJdunFiYH+nyZafi1cA8BgZ8Ekh+Ky+maD=KceC8rG5sptJA@mail.gmail.com>
To: Steven Wade <stevenwadejr@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d65cd9059dc03918"
Subject: Re: [PHP-DEV] [RFC - discussion] __toArray()
From: kontakt@beberlei.de (Benjamin Eberlei)

--000000000000d65cd9059dc03918
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 4, 2020 at 2:39 PM Steven Wade <stevenwadejr@gmail.com> wrote:

>
> I am open to the idea of having __toArray. I just have a few questions
> about the RFC details.
>
> 1. print_r($object) would somehow call __toArray you say. Why would it
> cause a cast when nothing else is cast? I would prefer print_r((array)
> $person);
>
>
> Originally I intended the proposal to be specific to user casting like yo=
u
> suggested but when writing the RFC I decided to pursue making the magic
> method and casting more in line with the behavior of __toString(). For
> example, when an object implements the __toString() method and you simply
> =E2=80=9Cecho $obj=E2=80=9D PHP automatically casts the object for you.
>

Yes, i see that it auto casts when you typehint for "array". print_r
argument is not array but mixed, so it should not cast the object to array
there.

>
> 2. In the parameter and return type examples you should add
> declare(strict_types=3D0); so it's clear this only works in weak mode.
>
>
> I think this is a good idea. I hadn=E2=80=99t looked into strict_types an=
d how it
> handles strings and their casting. Thanks!
>
> 3. The weak point of this proposal is the by reference handling for sort
> et al. Counterpoint: if you pass a variable to preg_match, then matches
> gets converted from anything to array, so i believe by reference casting
> should change the original value (https://3v4l.org/XUJ5m). This is weird,
> but consistent.
>
>
> The proposal states that =E2=80=9Carray functions that operate on an arra=
y by
> reference such as sort or shuffle will not work on an object
> implementing __toArray() under this proposal=E2=80=9D, and IMO that is co=
nsistent
> with other magical casting behaviors and I wouldn=E2=80=99t expect a clas=
s
> implementing __toArray() to be able to be written or referenced like a
> traditional array.
>

Passing an object with toString by reference will change the original
variable: https://3v4l.org/77lov

--000000000000d65cd9059dc03918--