Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108377
Message-ID: <516080A1-D777-49BD-A4A1-9978C2D558CB@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_C172DA83-3397-470F-B492-B846EC4FA8E8"
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\))
Date: Tue, 4 Feb 2020 08:39:31 -0500
In-Reply-To: <CAEPJdukNJ1QKswOH4eJ8=-ghtRiy8HCM+-uROz-2AOzrbTTsiQ@mail.gmail.com>
Cc: PHP Internals <internals@lists.php.net>
To: Benjamin Eberlei <kontakt@beberlei.de>
References: <D5ACEB01-4E1E-407A-8441-D8C6E0D36CCA@gmail.com>
 <CAEPJdukNJ1QKswOH4eJ8=-ghtRiy8HCM+-uROz-2AOzrbTTsiQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC - discussion] __toArray()
From: stevenwadejr@gmail.com (Steven Wade)

--Apple-Mail=_C172DA83-3397-470F-B492-B846EC4FA8E8
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> I am open to the idea of having __toArray. I just have a few questions =
about the RFC details.
>=20
> 1. print_r($object) would somehow call __toArray you say. Why would it =
cause a cast when nothing else is cast? I would prefer print_r((array) =
$person);

Originally I intended the proposal to be specific to user casting like =
you suggested but when writing the RFC I decided to pursue making the =
magic method and casting more in line with the behavior of __toString(). =
For example, when an object implements the __toString() method and you =
simply =E2=80=9Cecho $obj=E2=80=9D PHP automatically casts the object =
for you.

> 2. In the parameter and return type examples you should add =
declare(strict_types=3D0); so it's clear this only works in weak mode.

I think this is a good idea. I hadn=E2=80=99t looked into strict_types =
and how it handles strings and their casting. Thanks!

> 3. The weak point of this proposal is the by reference handling for =
sort et al. Counterpoint: if you pass a variable to preg_match, then =
matches gets converted from anything to array, so i believe by reference =
casting should change the original value (https://3v4l.org/XUJ5m =
<https://3v4l.org/XUJ5m>). This is weird, but consistent.

The proposal states that =E2=80=9Carray functions that operate on an =
array by reference such as sort or shuffle will not work on an object =
implementing __toArray() under this proposal=E2=80=9D, and IMO that is =
consistent with other magical casting behaviors and I wouldn=E2=80=99t =
expect a class implementing __toArray() to be able to be written or =
referenced like a traditional array.=

--Apple-Mail=_C172DA83-3397-470F-B492-B846EC4FA8E8--