Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108375
MIME-Version: 1.0
References: <D5ACEB01-4E1E-407A-8441-D8C6E0D36CCA@gmail.com>
In-Reply-To: <D5ACEB01-4E1E-407A-8441-D8C6E0D36CCA@gmail.com>
Date: Tue, 4 Feb 2020 14:33:06 +0100
Message-ID: <CAEPJdukNJ1QKswOH4eJ8=-ghtRiy8HCM+-uROz-2AOzrbTTsiQ@mail.gmail.com>
To: Steven Wade <stevenwadejr@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002242bd059dc01545"
Subject: Re: [PHP-DEV] [RFC - discussion] __toArray()
From: kontakt@beberlei.de (Benjamin Eberlei)

--0000000000002242bd059dc01545
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 4, 2020 at 2:03 PM Steven Wade <stevenwadejr@gmail.com> wrote:

> Hi all,
>
> I=E2=80=99d like to officially open my __toArray() RFC <
> https://wiki.php.net/rfc/to-array> up to discussion. I=E2=80=99ve delayed
> changing the status until I had more time to respond to the discussion, b=
ut
> since it=E2=80=99s been brought up again <https://externals.io/message/10=
8351>, I
> figured now is the best time.
>
> https://wiki.php.net/rfc/to-array <https://wiki.php.net/rfc/to-array>
>

I am open to the idea of having __toArray. I just have a few questions
about the RFC details.

1. print_r($object) would somehow call __toArray you say. Why would it
cause a cast when nothing else is cast? I would prefer print_r((array)
$person);

2. In the parameter and return type examples you should add
declare(strict_types=3D0); so it's clear this only works in weak mode.

3. The weak point of this proposal is the by reference handling for sort et
al. Counterpoint: if you pass a variable to preg_match, then matches gets
converted from anything to array, so i believe by reference casting should
change the original value (https://3v4l.org/XUJ5m). This is weird, but
consistent.

Cheers,
>
> Steven Wade

--0000000000002242bd059dc01545--