Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108330
Message-ID: <8A66CBA5-436F-4889-9262-9495A0340BE2@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_3C99AAF3-17CD-4512-A06E-252F3105C456"
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
Date: Thu, 30 Jan 2020 09:10:59 +0100
In-Reply-To: <CAEYWF=772_axjxni1216jeG2CbAZweCGMyfWDEOdk4N9aqrK4Q@mail.gmail.com>
Cc: Marco Pivetta <ocramius@gmail.com>,
 tyson andre <tysonandre775@hotmail.com>,
 "internals@lists.php.net" <internals@lists.php.net>
To: bishop@php.net
References: <DM5PR07MB30670BE1BAF74AAC2B4486DBF9050@DM5PR07MB3067.namprd07.prod.outlook.com>
 <CADyq6sLk9O8SF1As5OGFotqCnZva_1P9qigjR8QCB5+-BQ+SYw@mail.gmail.com>
 <CAEYWF=7pceCHWabne=zLNnOYsfdRLr7u07+h1R2ACodGViaEng@mail.gmail.com>
 <244D810D-4C45-4D02-A0B7-E625090C19A9@gmail.com>
 <CAEYWF=772_axjxni1216jeG2CbAZweCGMyfWDEOdk4N9aqrK4Q@mail.gmail.com>
Subject: Re: [PHP-DEV] [VOTE] declare(function_and_const_lookup='global')
From: claude.pache@gmail.com (Claude Pache)

--Apple-Mail=_3C99AAF3-17CD-4512-A06E-252F3105C456
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> Le 29 janv. 2020 =C3=A0 22:11, Bishop Bettini <bishop@php.net> a =
=C3=A9crit :
>=20
> On Wed, Jan 29, 2020 at 3:12 PM Claude Pache <claude.pache@gmail.com =
<mailto:claude.pache@gmail.com>> wrote:
>=20
>=20
>> Le 29 janv. 2020 =C3=A0 19:42, Bishop Bettini <bishop@php.net =
<mailto:bishop@php.net>> a =C3=A9crit :
>>=20
>> Cons... have to enumerate everything, potentially lots of work to do =
that
>> to update old code to use; edge cases I'm not thinking about.
>=20
>=20
> Not only it is much work (although it could be partially automated), =
but it does not make much sense.
>=20
> I=E2=80=99ve taken a random file (~650 LoC) in the codebase I=E2=80=99m =
working on. With `declare(strict_qualify=3D1)`, I would have to add:
>=20
> use function=20
>     array_filter
>   , array_flip
>   , array_key_exists
>   , array_keys
>   , array_push
>   , array_unshift
>   , compact
>   , ctype_digit
>   , idate
>   , in_array
>   , is_int
>   , is_string
>   , ksort
>   , ob_get_clean
>   , ob_start
>   , preg_match
>   , sprintf
>   , strlen
>   , strncmp
>   , substr_count
>   , trim
>   , usort;
>=20
> A fair critique. Under the "goad use of wildcard import" pro, the =
quick way:
> use \{*};

As of today, we already have something like `use function *`. We name it =
=E2=80=9Cfallback to the global scope=E2=80=9D.

The current RFC proposes an alternative approach, with its own =
advantages and inconveniences.

>=20
>=20
> Second, and I find this the best reason, that enumeration tells me =
quite a bit about what that code does. I don't need to see the code to =
know that it's compute oriented, doesn't touch resources (eg files), and =
is doing what PHP does best: string and array manipulation. It also =
shows me that code's doing output buffer manipulation, which seems out =
of place and suggests that should be refactored out.
>=20
> IOW, it's a really nice abstract / summary of what the code's doing. =
And that's some very good insight.

It=E2=80=99s an illusion: the enumeration of used global functions =
doesn=E2=80=99t say all. For instance, you cannot guess if the code =
writes on the filesystem by manipulating an instance of `SplFileObject` =
(or some other custom class), or not.

=E2=80=94Claude


--Apple-Mail=_3C99AAF3-17CD-4512-A06E-252F3105C456--