Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108324
MIME-Version: 1.0
References: <DM5PR07MB30670BE1BAF74AAC2B4486DBF9050@DM5PR07MB3067.namprd07.prod.outlook.com>
 <CADyq6sLk9O8SF1As5OGFotqCnZva_1P9qigjR8QCB5+-BQ+SYw@mail.gmail.com>
 <CAEYWF=7pceCHWabne=zLNnOYsfdRLr7u07+h1R2ACodGViaEng@mail.gmail.com> <244D810D-4C45-4D02-A0B7-E625090C19A9@gmail.com>
In-Reply-To: <244D810D-4C45-4D02-A0B7-E625090C19A9@gmail.com>
Reply-To: bishop@php.net
Date: Wed, 29 Jan 2020 16:11:28 -0500
Message-ID: <CAEYWF=772_axjxni1216jeG2CbAZweCGMyfWDEOdk4N9aqrK4Q@mail.gmail.com>
To: Claude Pache <claude.pache@gmail.com>
Cc: Marco Pivetta <ocramius@gmail.com>, tyson andre <tysonandre775@hotmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d4f7df059d4dca8a"
Subject: Re: [PHP-DEV] [VOTE] declare(function_and_const_lookup='global')
From: bishop@php.net (Bishop Bettini)

--000000000000d4f7df059d4dca8a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 29, 2020 at 3:12 PM Claude Pache <claude.pache@gmail.com> wrote=
:

>
>
> Le 29 janv. 2020 =C3=A0 19:42, Bishop Bettini <bishop@php.net> a =C3=A9cr=
it :
>
> Cons... have to enumerate everything, potentially lots of work to do that
> to update old code to use; edge cases I'm not thinking about.
>
>
> Not only it is much work (although it could be partially automated), but
> it does not make much sense.
>
> I=E2=80=99ve taken a random file (~650 LoC) in the codebase I=E2=80=99m w=
orking on. With
> `declare(strict_qualify=3D1)`, I would have to add:
>
> use function
>     array_filter
>   , array_flip
>   , array_key_exists
>   , array_keys
>   , array_push
>   , array_unshift
>   , compact
>   , ctype_digit
>   , idate
>   , in_array
>   , is_int
>   , is_string
>   , ksort
>   , ob_get_clean
>   , ob_start
>   , preg_match
>   , sprintf
>   , strlen
>   , strncmp
>   , substr_count
>   , trim
>   , usort;
>

A fair critique. Under the "goad use of wildcard import" pro, the quick way=
:
use \{*};

Any unqualified name is locked to the global namespace.

> I don=E2=80=99t see a clear advantage in declaring more than 20 global fu=
nctions
> in each and every of the hundreds of files of the codebase=E2=80=94where =
it is
> evident that they are all global function (no, I don=E2=80=99t have a nam=
espaced
> version of `is_int()`). Also, I think that there are better ways to
> discover if my colleague introduced surreptitiously a `system()` call in
> the codebase.
>

Well, first, it's faster as Tyson described in the RFC: those are opcoded
and bypass the namespace lookup.

Second, and I find this the best reason, that enumeration tells me quite a
bit about what that code does. I don't need to see the code to know that
it's compute oriented, doesn't touch resources (eg files), and is doing
what PHP does best: string and array manipulation. It also shows me that
code's doing output buffer manipulation, which seems out of place and
suggests that should be refactored out.

IOW, it's a really nice abstract / summary of what the code's doing. And
that's some very good insight.


> Some time ago, I=E2=80=99ve tried the alternative approach in two files: =
adding a
> backslash before each and every global function (carefully avoiding
> non-functions such as `isset()`, `empty()` and `list()`). Well, it remind=
ed
> me of the good old days when I used TeX intensively, but objectively, it
> didn=E2=80=99t make the code more clear or more secure (I=E2=80=99ve not =
tested its
> velocity, though).
>

I agree: qualifying the name at the usage site doesn't add much value, IMO.
It's frankly more noise than anything else.

--000000000000d4f7df059d4dca8a--