Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108323
Message-ID: <244D810D-4C45-4D02-A0B7-E625090C19A9@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_AABDE563-0572-454A-8243-EAF3BB78652C"
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
Date: Wed, 29 Jan 2020 21:12:17 +0100
In-Reply-To: <CAEYWF=7pceCHWabne=zLNnOYsfdRLr7u07+h1R2ACodGViaEng@mail.gmail.com>
Cc: Marco Pivetta <ocramius@gmail.com>,
 tyson andre <tysonandre775@hotmail.com>,
 "internals@lists.php.net" <internals@lists.php.net>
To: bishop@php.net
References: <DM5PR07MB30670BE1BAF74AAC2B4486DBF9050@DM5PR07MB3067.namprd07.prod.outlook.com>
 <CADyq6sLk9O8SF1As5OGFotqCnZva_1P9qigjR8QCB5+-BQ+SYw@mail.gmail.com>
 <CAEYWF=7pceCHWabne=zLNnOYsfdRLr7u07+h1R2ACodGViaEng@mail.gmail.com>
Subject: Re: [PHP-DEV] [VOTE] declare(function_and_const_lookup='global')
From: claude.pache@gmail.com (Claude Pache)

--Apple-Mail=_AABDE563-0572-454A-8243-EAF3BB78652C
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> Le 29 janv. 2020 =C3=A0 19:42, Bishop Bettini <bishop@php.net> a =
=C3=A9crit :
>=20
> Cons... have to enumerate everything, potentially lots of work to do =
that
> to update old code to use; edge cases I'm not thinking about.


Not only it is much work (although it could be partially automated), but =
it does not make much sense.

I=E2=80=99ve taken a random file (~650 LoC) in the codebase I=E2=80=99m =
working on. With `declare(strict_qualify=3D1)`, I would have to add:

use function=20
    array_filter
  , array_flip
  , array_key_exists
  , array_keys
  , array_push
  , array_unshift
  , compact
  , ctype_digit
  , idate
  , in_array
  , is_int
  , is_string
  , ksort
  , ob_get_clean
  , ob_start
  , preg_match
  , sprintf
  , strlen
  , strncmp
  , substr_count
  , trim
  , usort;

I don=E2=80=99t see a clear advantage in declaring more than 20 global =
functions in each and every of the hundreds of files of the =
codebase=E2=80=94where it is evident that they are all global function =
(no, I don=E2=80=99t have a namespaced version of `is_int()`). Also, I =
think that there are better ways to discover if my colleague introduced =
surreptitiously a `system()` call in the codebase.

Some time ago, I=E2=80=99ve tried the alternative approach in two files: =
adding a backslash before each and every global function (carefully =
avoiding non-functions such as `isset()`, `empty()` and `list()`). Well, =
it reminded me of the good old days when I used TeX intensively, but =
objectively, it didn=E2=80=99t make the code more clear or more secure =
(I=E2=80=99ve not tested its velocity, though).

=E2=80=94Claude


--Apple-Mail=_AABDE563-0572-454A-8243-EAF3BB78652C--