Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108281
MIME-Version: 1.0
References: <CAG9XoMQBi0bWwwcX6pbg-f3TGHAOo6cRKXQTCKB2Z28VjseS8Q@mail.gmail.com>
 <CAF+90c9B+1hErd+kfh2AbkpUuLwKYpgTvvUqX87WLNCWVLn9YA@mail.gmail.com>
In-Reply-To: <CAF+90c9B+1hErd+kfh2AbkpUuLwKYpgTvvUqX87WLNCWVLn9YA@mail.gmail.com>
Date: Tue, 28 Jan 2020 05:46:08 +0200
Message-ID: <CAAwdEzDgfXvsi+TGoKZp=cArUEMpAPdpPa=Fzi9r5jJ4e4nWrw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Benjamin Morel <benjamin.morel@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000443eeb059d2b11e1"
Subject: Re: [PHP-DEV] Union types | true pseudo-type
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000443eeb059d2b11e1
Content-Type: text/plain; charset="UTF-8"

On Mon, Jan 27, 2020 at 11:43 AM Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Mon, Jan 20, 2020 at 6:30 PM Benjamin Morel <benjamin.morel@gmail.com>
> wrote:
>
> > Hi internals,
> >
> > I'd like to bring back the topic of supporting "true" as a type in PHP 8
> > union types.
> > Now that the RFC <https://wiki.php.net/rfc/union_types_v2> has been
> > successfully voted, I'd like to revive the discussion about adding the
> > "true" pseudo-type in addition to "false".
> >
> > In addition to my Packagist survey
> > <https://externals.io/message/106844#107304>, I'd like to point out
> that I
> > just came across a native method in the SSH2 extension, that does use
> true
> > as a type:
> >
> > https://www.php.net/manual/en/function.ssh2-auth-none.php
> >
> >
> > Returns TRUE if the server does accept "none" as an authentication
> method,
> > > or an array of accepted authentication methods on failure.
> >
> >
> >
> > Of course, you could type-hint it array|bool, but the same could be said
> > for |false.
> >
> > Thoughts?
> >
>
> Generally I'm fine with also allowing the "true" type. We certainly have
> quite a few extension methods that return isolated true values for legacy
> reasons. However, before "true" is allowed, it is important to answer the
> two questions at the end of
> https://wiki.php.net/rfc/union_types_v2#literal_types.
>
> Namely, how do true/false interact with weak typing coercions (currently
> "false" only accepts "false", but not 0 or "") and whether true|false
> should be equivalent to bool (also related to the previous question).
>
> Regards,
> Nikita
>

Hi,

I think we can continue in a similar conservative approach, without
coercion for *true*, similar as for *false*.
For the cases mentioned so far, we are interested in exactly the true
value, not true-ish value like 1.

This would make *true|false* not equivalent with *bool* when strict_types
is not enabled
and equivalent when strict_types is enabled.

Alex

--000000000000443eeb059d2b11e1--